Conversation
- fix(context-descriptor): dispatch ReadingContext generic context via TypeContextDescriptorProtocol (resolves EXC_BAD_ACCESS in MultiPayloadEnumTests and GenericSpecializationTests via SwiftInterfaceIndexer.indexTypes). - deps: bump swift-demangling minimum to 0.3.0; adopt async demangleAsNode / Node.print / mangleAsString across dumpers, the interface builder, and test suites. - ci(macos): cover generic-context regression suites in the filter regex. - ci(version): make Sources/swift-section/Version.swift the single source of truth; enforce matching Changelogs/<value>.md on PRs and matching tag on release. - docs: correct MachOKit version in 0.10.0 notes; note SymbolIndexStore race CI occurrences.
There was a problem hiding this comment.
Pull request overview
Patch release housekeeping for 0.10.1, aligning the CLI’s bundled version with the new changelog entry as part of the repo’s release/version enforcement flow.
Changes:
- Bumped
BundledVersion.valuefrom0.10.0to0.10.1. - Added
Changelogs/0.10.1.mdrelease notes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Sources/swift-section/Version.swift |
Updates the bundled CLI version string to 0.10.1. |
Changelogs/0.10.1.md |
Adds the 0.10.1 changelog entry referenced by CI/release workflows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 0.10.1 and adds a comprehensive changelog. Key changes include a fix for a signal-11 crash in generic-context dispatch, updates for swift-demangling 0.3.0 async APIs, and CI workflow improvements. Feedback identifies likely typos in the system requirements (Swift and Xcode versions) and recommends using relative links for documentation to ensure better portability.
| - Swift 6.2+ | ||
| - Xcode 26.0+ (CI validates on Xcode 26.4 / macOS 26) |
There was a problem hiding this comment.
The version requirements for Swift, Xcode, and macOS appear to be typos. Swift 6.0, Xcode 16.0, and macOS 15 are the current major versions. Using "6.2", "26.0", and "26" seems incorrect and could mislead users about the project's compatibility.
| - Swift 6.2+ | |
| - Xcode 26.0+ (CI validates on Xcode 26.4 / macOS 26) | |
| - Swift 6.0+ | |
| - Xcode 16.0+ (CI validates on Xcode 16.0 / macOS 15) |
|
|
||
| ## Known Issues | ||
|
|
||
| See [KNOWN_ISSUES.md](https://github.com/MxIris-Reverse-Engineering/MachOSwiftSection/blob/0.10.1/KNOWN_ISSUES.md) — same two non-blocking parallel-harness concurrency items as 0.10.0. |
There was a problem hiding this comment.
Use a relative link for KNOWN_ISSUES.md instead of an absolute URL. This ensures the link remains valid across different forks and if the repository is renamed or moved.
| See [KNOWN_ISSUES.md](https://github.com/MxIris-Reverse-Engineering/MachOSwiftSection/blob/0.10.1/KNOWN_ISSUES.md) — same two non-blocking parallel-harness concurrency items as 0.10.0. | |
| See [KNOWN_ISSUES.md](../KNOWN_ISSUES.md) — same two non-blocking parallel-harness concurrency items as 0.10.0. |
|
Superseded by #79. Scope expanded from patch |
Summary
EXC_BAD_ACCESSinMultiPayloadEnumTests/GenericSpecializationTestsviaSwiftInterfaceIndexer.indexTypes).swift-demanglingminimum to0.3.0and adopts the new asyncdemangleAsNode/Node.print/mangleAsStringAPIs across dumpers, the interface builder, and test suites.BundledVersion.valueinSources/swift-section/Version.swiftto the single source of truth for the CLI version, enforced byversion-check.yml(matchingChangelogs/<value>.md) andrelease.yml(matching tag).Test plan
Version Checkworkflow is green (confirmsChangelogs/0.10.1.mdexists and matchesBundledVersion.value)MultiPayloadEnumTestswith no signal-11GenericSpecializationTests,GenericSpecializerAPITests,MetadataReaderDemanglingTestsswift test --filter MachOSwiftSectionTestsgreen0.10.1cuts a clean release (release.yml verification step passes)