Open
Conversation
unnecessary file
…MPACT/pyQuARC into feature-add_new_checks-la
lavanya3k
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revised PR addresses the Entry Title and Data center contact information. When testing, it was found that the local branch did not flag RelatedUrls/Description. It also showed a couple of error flags unnecessary for this ticket. The flags that were removed are
Collection/OnlineResources/OnlineResource/Type and ProcessingLevel/ProcessingLevelDescription.
Overview: When checking for the Entry Title and DataCenters/ContactGroups/ContactInformation/ContactMechanisms/Value, we saw that RelatedUrls/Description disappeared (check with master branch). There was a code conflict with the following rules in
rules_mapping_override.jsonandcheck_messages_override.json.Removed the following logic in the rules_mapping_override.json. The changes are available in another ticket; hence, we don't want to create merge conflicts.
processing_level_description_presence_check
online_resource_type_presence_check
url_desc_presence_check - Change check_id: availability_check (Previously it was one_item_presence_check).
To Reproduce:
C1000000018-CDDIS --format umm-c
C1000000010-CDDIS --format umm-c
Expected behavior:
