Additional Online Access and Resources - updated#356
Merged
Conversation
slesaad
approved these changes
Oct 15, 2025
Collaborator
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a new PR for the issue #298
Description of the bug: For the Collection, OnlineResource/Description, OnlineResource/Type, or OnlineAccess/Description, pyQuARC does not flag them or flags red for Related URL Type because it pulls several URLs from View related information (See the screenshot from #304). The best way to fix this bug involves three steps.
In the rule_mapping.json - Look at the
url_desc_presence_check,online_resource_type_presence_check, and online_resource_type_gcmd_check checks. Change the check_id to one_item_presence_check instead of availability_check for all these sections.Add "RelatedUrls/Description" and "RelatedUrls/URL" along with "Collection/OnlineResources/OnlineResource/Description",
"Collection/OnlineResources/OnlineResource/URL" in the url_desc_presence_check. Repeat the checks for the remaining two sections. These changes should be uniform per the wiki page and schema to perform the URL Type and description checks.
Testing concept IDs:
G1001434969-CDDIS --format umm-g
C1000000010-CDDIS --format umm-c
C1000000044-CDDIS --format umm-c
Expected outcome: