Normalize

[cbizon]

Define the normalize nodes operation

[dkoslicki]

Should this file be names something like 01_prenormalized_message.json instead of premerged?

[dkoslicki]

Same with the name of this file

[dkoslicki]

Should there be a hyphen here?

[dkoslicki]

Let's make this a non-unique operation (so there is only one way to do the normalization)

[cbizon]

Thanks @dkoslicki . I've updated the filenames / dash.

I'm not sure how to designate unique/nonunique. I took a look at sort and some others that I thought should be nonunique and didn't see any kind of annotation there. Can you point me in the right direction?

[dkoslicki]

Here's an example of the unique flag: https://github.com/NCATSTranslator/OperationsAndWorkflows/blob/main/operations/fill.yml#L4
I assume we should set this to unique=False, but @uhbrar can check me on that

[uhbrar]

@dkoslicki is right. This should be tagged as unique=False, although it actually doesn't need to be tagged at all, since the default is False. The current operations schema dictates that only unique operations need to be tagged as unique. Non-unique operations can be tagged as non-unique, or can be left un-tagged.

Here's an example: https://github.com/NCATSTranslator/OperationsAndWorkflows/blob/main/operations/bind.yml

[cbizon]

Aha, explains why I didn't see unique in the places I was looking. I went ahead and added it explicitly to this one.

[uhbrar]

That shouldn't be a problem. However, before this is merged, the schema needs to be rebuilt first. This is done through schema/build/generate_schema.py

[cbizon]

Oh right. I've also updated the README with a reminder on the process.