Skip to content

Ccm 7485 test #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kennedy1265 wants to merge 2 commits into from
Closed

Ccm 7485 test #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ff6e62
CCM-7485: Billing reference doc update
simonlabarere Jun 12, 2025
abf7c92
CCM-7485: repointed frontend
Kennedy1265 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions proxies/live/apiproxy/targets/target.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,14 @@
<SSLInfo>
<Enabled>true</Enabled>
</SSLInfo>
<LoadBalancer>
<Server name="{{ TARGET_SERVER_OVERRIDE | default('communications-manager-target') }}"/>
</LoadBalancer>
<Path>{requestpath}</Path>
{% if ENVIRONMENT_TYPE == 'sandbox' %}
<LoadBalancer>
<Server name="{{ TARGET_SERVER_OVERRIDE | default('communications-manager-target') }}"/>
</LoadBalancer>
<Path>{requestpath}</Path>
{% else %}
<URL>https://comms-apim.de-rake4.communications.national.nhs.uk</URL>
{% endif %}
<Properties>
<Property name="io.timeout.millis">29000</Property>
</Properties>
Expand Down
15 changes: 11 additions & 4 deletions proxies/shared/policies/AssignMessage.MessageBatches.Create.Request.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,17 @@
<Name>target.copy.pathsuffix</Name>
<Value>false</Value>
</AssignVariable>
<AssignVariable>
<Name>requestpath</Name>
<Value>/api/v1/send</Value>
</AssignVariable>
{% if ENVIRONMENT_TYPE == 'sandbox' %}
<AssignVariable>
<Name>requestpath</Name>
<Value>/api/v1/send</Value>
</AssignVariable>
{% else %}
<AssignVariable>
<Name>target.url</Name>
<Value>https://comms-apim.de-rake4.communications.national.nhs.uk/api/v1/send</Value>
</AssignVariable>
{% endif %}
<Set>
<Payload contentType="application/json" variablePrefix="%" variableSuffix="#">%data.payload#</Payload>
<Headers>
Expand Down
15 changes: 11 additions & 4 deletions proxies/shared/policies/AssignMessage.Messages.Create.Request.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,17 @@
<Name>target.copy.pathsuffix</Name>
<Value>false</Value>
</AssignVariable>
<AssignVariable>
<Name>requestpath</Name>
<Value>/api/v1/messages</Value>
</AssignVariable>
{% if ENVIRONMENT_TYPE == 'sandbox' %}
<AssignVariable>
<Name>requestpath</Name>
<Value>/api/v1/messages</Value>
</AssignVariable>
{% else %}
<AssignVariable>
<Name>target.url</Name>
<Value>https://comms-apim.de-rake4.communications.national.nhs.uk/api/v1/messages</Value>
</AssignVariable>
{% endif %}
<Set>
<Payload contentType="application/json" variablePrefix="%" variableSuffix="#">%data.payload#</Payload>
<Headers>
Expand Down
15 changes: 11 additions & 4 deletions proxies/shared/policies/AssignMessage.Messages.GetSingle.Request.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,17 @@
<Name>target.copy.pathsuffix</Name>
<Value>false</Value>
</AssignVariable>
<AssignVariable>
<Name>requestpath</Name>
<Template>/api/v1/messages/{data.messageId}</Template>
</AssignVariable>
{% if ENVIRONMENT_TYPE == 'sandbox' %}
<AssignVariable>
<Name>requestpath</Name>
<Template>/api/v1/messages/{data.messageId}</Template>
</AssignVariable>
{% else %}
<AssignVariable>
<Name>target.url</Name>
<Value>https://comms-apim.de-rake4.communications.national.nhs.uk/api/v1/messages/{data.messageId}</Value>
</AssignVariable>
{% endif %}
<Set>
<Headers>
<Header name="X-Correlation-Id">{backendCorrelationId}</Header>
Expand Down
15 changes: 11 additions & 4 deletions proxies/shared/policies/AssignMessage.NhsAppAccounts.Get.Request.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,17 @@
<Name>target.copy.pathsuffix</Name>
<Value>false</Value>
</AssignVariable>
<AssignVariable>
<Name>requestpath</Name>
<Value>/api/channels/nhsapp/accounts</Value>
</AssignVariable>
{% if ENVIRONMENT_TYPE == 'sandbox' %}
<AssignVariable>
<Name>requestpath</Name>
<Value>/api/channels/nhsapp/accounts</Value>
</AssignVariable>
{% else %}
<AssignVariable>
<Name>target.url</Name>
<Value>https://comms-apim.de-rake4.communications.national.nhs.uk/api/channels/nhsapp/accounts</Value>
</AssignVariable>
{% endif %}
<Set>
<Headers>
<Header name="X-Correlation-Id">{backendCorrelationId}</Header>
Expand Down
2 changes: 2 additions & 0 deletions specification/schemas/components/Message.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ properties:
description: This reference needs to be unique per message within this batch. If there are duplicate values then a 400 exception will be thrown highlighting the values that have been duplicated.
format: uuid
example: 703b8008-545d-4a04-bb90-1f2946ce1575
billingReference:
$ref: ../../snippets/BillingReferenceSnippet.yaml
recipient:
$ref: Recipient.yaml
originator:
Expand Down
2 changes: 2 additions & 0 deletions specification/schemas/requests/CreateMessage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ properties:

This value is used internally to de-duplicate messages. If you send the same value through multiple times only one of the requests will be actioned.
example: da0b1495-c7cb-468c-9d81-07dee089d728
billingReference:
$ref: ../../snippets/BillingReferenceSnippet.yaml
recipient:
$ref: ../components/Recipient.yaml
originator:
Expand Down
3 changes: 3 additions & 0 deletions specification/snippets/BillingReferenceSnippet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
type: string
description: Optional reference for billing purposes. Can be any string.
example: billing-ref-1