Skip to content

CCM-10553: Fix Dependabot Redoc #955

Merged
ScottFullerton-NHSE merged 5 commits into
releasefrom
feature/CCM-10553-fix-dependabot-packages
Jun 18, 2025
Merged

CCM-10553: Fix Dependabot Redoc #955
ScottFullerton-NHSE merged 5 commits into
releasefrom
feature/CCM-10553-fix-dependabot-packages

Conversation

@ScottFullerton-NHSE
Copy link
Copy Markdown
Contributor

Summary

I've run pnpm update -r to update the files to see if this will fix the dependabot issue. However, it looks to have updated possibly more then we originally wanted. I've put this PR here to see what others think before attempting to merge it and see if it clears.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-10553

Copy link
Copy Markdown
Contributor

@tdroza-nhs tdroza-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a lot of change here but all-but-one appear to be minor or patch version updates that I'm not too concerned about. However, the one that worries me is ajv as that's 4 major version increments!

    "ajv": "4.11.8 - 8",
    "ajv": "^8.17.1",

I think it might be safer to back that one out of this PR and apply it separately under another ticket so that if it does cause issues we can roll it back without reverting all of the other updates

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-10553

Comment thread package.json Outdated
@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-10553

Copy link
Copy Markdown
Contributor

@simonlabarere simonlabarere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to investigate the sandbox unit test failures before merging this.

@simonlabarere simonlabarere dismissed their stale review June 18, 2025 08:24

Nevermind, this could not be reproduced locally and the sandbox pipeline passed the second time.

@ScottFullerton-NHSE ScottFullerton-NHSE merged commit 95fb767 into release Jun 18, 2025
6 checks passed
@ScottFullerton-NHSE ScottFullerton-NHSE deleted the feature/CCM-10553-fix-dependabot-packages branch June 18, 2025 09:44
ScottFullerton-NHSE added a commit that referenced this pull request Jun 18, 2025
ScottFullerton-NHSE added a commit that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants