Skip to content

CCM-10447 Update for new failed reason codes#963

Merged
Ian-Hodges merged 11 commits into
releasefrom
feature/CCM-10447_get-message-failure-code
Aug 6, 2025
Merged

CCM-10447 Update for new failed reason codes#963
Ian-Hodges merged 11 commits into
releasefrom
feature/CCM-10447_get-message-failure-code

Conversation

@Ian-Hodges
Copy link
Copy Markdown
Contributor

@Ian-Hodges Ian-Hodges commented Jul 9, 2025

Summary

Updates for new messageFailureReasonCode and channelFailureReasonCode fields returned by the get message endpoint.

  • Examples added to the sandbox responses.
  • Specification document updated.
  • New successful failed status e2e test.

Test Evidence

Test evidence added to CCM-10447.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 9, 2025

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-10447

@NHSDigital NHSDigital deleted a comment from github-actions Bot Jul 10, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Jul 10, 2025
Comment thread proxies/live/apiproxy/targets/target.xml Outdated
simonlabarere
simonlabarere previously approved these changes Aug 1, 2025
Comment thread sandbox/messages/2WL45YuHOLATvC3GspEu0oSioux.json
Copy link
Copy Markdown
Contributor

@simonlabarere simonlabarere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test potentially showing an issue with comms-mgr?

FAILED tests/api/message_batches/test_201_success.py::test_201_message_batch_terminal_failed_status - AssertionError: assert 
  None
  
    ==
  'MFR_CFGV_0005'
FAILED tests/api/single_message/test_201_success.py::test_201_message_terminal_failed_status - AssertionError: assert 
  None
  
    ==
  'MFR_CFGV_0005'

@Ian-Hodges
Copy link
Copy Markdown
Contributor Author

Is this test potentially showing an issue with comms-mgr?

FAILED tests/api/message_batches/test_201_success.py::test_201_message_batch_terminal_failed_status - AssertionError: assert 
  None
  
    ==
  'MFR_CFGV_0005'
FAILED tests/api/single_message/test_201_success.py::test_201_message_terminal_failed_status - AssertionError: assert 
  None
  
    ==
  'MFR_CFGV_0005'

It's because it's no longer pointing to de-iaho3 and internal-dev doesn't have the changes yet. There's evidence of a successful deployment in the ticket.

@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot Aug 6, 2025
@Ian-Hodges Ian-Hodges merged commit d4d859d into release Aug 6, 2025
6 checks passed
@Ian-Hodges Ian-Hodges deleted the feature/CCM-10447_get-message-failure-code branch August 6, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants