Skip to content

feat: DTOSS 12465 & DTOSS-12527 Remove Dummy GP API validation and PDS lookup#1872

Open
hardik-desai-nhs wants to merge 9 commits intomainfrom
DTOSS-12465-Remove-Dummy-GP-API-validation-and-PDS-lookup
Open

feat: DTOSS 12465 & DTOSS-12527 Remove Dummy GP API validation and PDS lookup#1872
hardik-desai-nhs wants to merge 9 commits intomainfrom
DTOSS-12465-Remove-Dummy-GP-API-validation-and-PDS-lookup

Conversation

@hardik-desai-nhs
Copy link
Copy Markdown
Contributor

Description

Added new Function project to receive api call for Remove Dummy GP

Added new Function project to receive api call for Remove Dummy GP

Context

People exist in the cohort and in PDS with an incorrect Reason for Removal code within the removed from GP Practice Category code (RDR, RPR, RDI). The current process removes these and will assign that person to a Dummy GP code based on the Post Code and previous GP code. In some instances, we have had reports that this is incorrect and the person is embarked or some other reason for them to no longer be eligible for screening
Previously in PI these individuals will have been manually overwritten with an ORR Reason for Removal Code.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link
Copy Markdown

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@github-actions
Copy link
Copy Markdown

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@github-actions
Copy link
Copy Markdown

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@hardik-desai-nhs hardik-desai-nhs changed the title DTOSS 12465 & DTOSS-12527 Remove Dummy GP API validation and PDS ookup feat: DTOSS 12465 & DTOSS-12527 Remove Dummy GP API validation and PDS ookup Mar 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Unit Test Results

✔️ Tests 1028 / 1028 - passed in 63.6s
📝 Coverage 47.54%
📏 4894 / 10593 lines covered 🌿 1205 / 2236 branches covered
🔍 click here for more details

✏️ updated for commit 54f0951

@hardik-desai-nhs hardik-desai-nhs marked this pull request as ready for review March 25, 2026 15:30
@hardik-desai-nhs hardik-desai-nhs changed the title feat: DTOSS 12465 & DTOSS-12527 Remove Dummy GP API validation and PDS ookup feat: DTOSS 12465 & DTOSS-12527 Remove Dummy GP API validation and PDS lookup Mar 26, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants