Chore: [AEA-0000] - remove cdk_pull_image_role#1046
Merged
anthony-nhs merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
There was a problem hiding this comment.
Pull request overview
Removes the CDK_PULL_IMAGE_ROLE secret wiring from this repo’s GitHub Actions workflows, aligning the calling workflows and the reusable cdk_release_code.yml interface so the role is no longer expected or passed during CI/release deployments.
Changes:
- Removed
CDK_PULL_IMAGE_ROLEfrom CI, PR, and release workflow secret mappings. - Updated the reusable workflow
.github/workflows/cdk_release_code.ymlto no longer declareCDK_PULL_IMAGE_ROLEas a required secret.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Stops passing CDK_PULL_IMAGE_ROLE into environment release jobs. |
| .github/workflows/pull_request.yml | Stops passing CDK_PULL_IMAGE_ROLE into PR deployment workflow call. |
| .github/workflows/ci.yml | Stops passing CDK_PULL_IMAGE_ROLE into CI release jobs. |
| .github/workflows/cdk_release_code.yml | Removes CDK_PULL_IMAGE_ROLE from workflow_call.secrets contract. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details