New: [AEA-6256] - update to API gateway and StateMachine constructs#648
Merged
tstephen-nhs merged 14 commits intomainfrom Apr 1, 2026
Merged
New: [AEA-6256] - update to API gateway and StateMachine constructs#648tstephen-nhs merged 14 commits intomainfrom
tstephen-nhs merged 14 commits intomainfrom
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6256 |
tstephen-nhs
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cdkConstructs package to make the REST API Gateway construct more configurable around custom domain provisioning, improves how cfn-guard suppressions are applied, and extends DNS support to IPv6.
Changes:
- Add
enableServiceDomaintoRestApiGatewayto optionally skip creating custom domain/certificate/Route53 records (default remains enabled). - Refactor cfn-guard suppressions to use a shared helper/constant (merging rather than overwriting metadata).
- Add an IPv6 (AAAA) Route53 record alongside the existing A record for the API Gateway alias.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cdkConstructs/tests/constructs/RestApiGateway.test.ts | Updates existing tests for the new prop and adds a default-behaviour test around domain resource creation. |
| packages/cdkConstructs/src/constructs/lambdaSharedResources.ts | Switches log-group cfn-guard suppression to use a shared rule constant. |
| packages/cdkConstructs/src/constructs/StateMachine.ts | Switches log-group cfn-guard suppression to the shared helper/constant (merging metadata). |
| packages/cdkConstructs/src/constructs/RestApiGateway/StateMachineEndpoint.ts | Adds an additional declared method response status code (408). |
| packages/cdkConstructs/src/constructs/RestApiGateway.ts | Introduces enableServiceDomain, adds AAAA record support, and uses suppression helper for stage metadata. |
| packages/cdkConstructs/src/constants.ts | Adds CFN_GUARD_RULES for shared cfn-guard rule identifiers. |
packages/cdkConstructs/src/constructs/RestApiGateway/StateMachineEndpoint.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
anthony-nhs
reviewed
Apr 1, 2026
anthony-nhs
reviewed
Apr 1, 2026
anthony-nhs
reviewed
Apr 1, 2026
tstephen-nhs
force-pushed
the
aea-6256-updates
branch
from
585ccdb to
bdf808f
Compare
|
anthony-nhs
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details