Chore: [AEA-0000] - remove pushing cdk image#649
Merged
anthony-nhs merged 5 commits intomainfrom Mar 30, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the internal “cdk-utils-build” Docker image build/push pipeline from this repository, leaving release/CI focused on quality checks and NPM package publishing.
Changes:
- Deletes the CDK deployment Docker image definition and entrypoint scripts.
- Removes reusable GitHub Actions workflows for building/uploading the Docker image.
- Strips Docker image build/upload jobs from CI, PR, and release workflows.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
docker/entrypoint.sh |
Removed CDK deploy/diff container entrypoint script. |
docker/Dockerfile |
Removed Docker image build definition for the CDK deployment image. |
.github/workflows/release.yml |
Removed Docker image build/upload stages from the release workflow. |
.github/workflows/pull_request.yml |
Removed PR Docker image build/upload stages. |
.github/workflows/ci.yml |
Removed Docker image build/upload stages on merges to main. |
.github/workflows/docker_image_upload.yml |
Deleted reusable workflow for pushing the Docker image to ECR. |
.github/workflows/docker_image_build.yml |
Deleted reusable workflow for building/saving the Docker image artifact. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:58
- In this workflow,
get_commit_idis still executed and listed inneeds:forquality_checks,tag_release, andpackage_npm_code, but its outputs are not referenced anywhere (needs.get_commit_id.outputs.*doesn’t appear in the file). If there’s no external dependency on that job, consider removingget_commit_idand dropping it fromneeds:to simplify and speed up the workflow.
tag_release:
needs: [quality_checks, get_commit_id, get_config_values]
uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
with:
dry_run: true
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
branch_name: main
publish_packages: packages/cdkConstructs,packages/deploymentUtils
tag_format: ${{ needs.get_config_values.outputs.tag_format }}
secrets: inherit
package_npm_code:
needs: [quality_checks, get_commit_id, get_config_values]
uses: ./.github/workflows/package_npm_code.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
|
tstephen-nhs
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Details