Skip to content

Chore: [AEA-0000] - remove pushing cdk image#649

Merged
anthony-nhs merged 5 commits intomainfrom
remove_cdk_image
Mar 30, 2026
Merged

Chore: [AEA-0000] - remove pushing cdk image#649
anthony-nhs merged 5 commits intomainfrom
remove_cdk_image

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

  • remove pushing cdk image

Copilot AI review requested due to automatic review settings March 30, 2026 12:18
@github-actions
Copy link
Copy Markdown
Contributor

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-0000

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the internal “cdk-utils-build” Docker image build/push pipeline from this repository, leaving release/CI focused on quality checks and NPM package publishing.

Changes:

  • Deletes the CDK deployment Docker image definition and entrypoint scripts.
  • Removes reusable GitHub Actions workflows for building/uploading the Docker image.
  • Strips Docker image build/upload jobs from CI, PR, and release workflows.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docker/entrypoint.sh Removed CDK deploy/diff container entrypoint script.
docker/Dockerfile Removed Docker image build definition for the CDK deployment image.
.github/workflows/release.yml Removed Docker image build/upload stages from the release workflow.
.github/workflows/pull_request.yml Removed PR Docker image build/upload stages.
.github/workflows/ci.yml Removed Docker image build/upload stages on merges to main.
.github/workflows/docker_image_upload.yml Deleted reusable workflow for pushing the Docker image to ECR.
.github/workflows/docker_image_build.yml Deleted reusable workflow for building/saving the Docker image artifact.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:58

  • In this workflow, get_commit_id is still executed and listed in needs: for quality_checks, tag_release, and package_npm_code, but its outputs are not referenced anywhere (needs.get_commit_id.outputs.* doesn’t appear in the file). If there’s no external dependency on that job, consider removing get_commit_id and dropping it from needs: to simplify and speed up the workflow.
  tag_release:
    needs: [quality_checks, get_commit_id, get_config_values]
    uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
    with:
      dry_run: true
      pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
      branch_name: main
      publish_packages: packages/cdkConstructs,packages/deploymentUtils
      tag_format: ${{ needs.get_config_values.outputs.tag_format }}
    secrets: inherit

  package_npm_code:
    needs: [quality_checks, get_commit_id, get_config_values]
    uses: ./.github/workflows/package_npm_code.yml
    with:
      pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}

@sonarqubecloud
Copy link
Copy Markdown

@anthony-nhs anthony-nhs merged commit 2fa86a2 into main Mar 30, 2026
13 checks passed
@anthony-nhs anthony-nhs deleted the remove_cdk_image branch March 30, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants