Skip to content

Fix: [AEA-0000] - Stopped trigger_release script from releasing to int and fixed it for multi phase approvals #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthewPopat-NHS merged 2 commits into from
Mar 30, 2026
Merged

Fix: [AEA-0000] - Stopped trigger_release script from releasing to int and fixed it for multi phase approvals #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e13557
Stopped trigger_release script from releasing to int and fixed it for…
MatthewPopat-NHS Mar 30, 2026
43cdb18
Merge branch 'main' into fix_release_script
MatthewPopat-NHS Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions scripts/trigger_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ def __init__(self, token: str, owner: str, repo: str, logger: logging.Logger):
self.version_tag: Optional[str] = None
self.jobs_requiring_approval = [
"release_ref",
"release_qa",
"release_int"
"release_qa"
]
self.approved_jobs = set()
self.completed_jobs = set()
Expand Down Expand Up @@ -207,28 +206,28 @@ def monitor_and_approve(self) -> bool:
env_name = deployment["environment"]["name"]
env_id = deployment["environment"]["id"]

# Check if this is release_prod
if env_name == "prod":
# Check if this is release_int
if env_name == "int":
self.logger.info(
f"\n🛑 Reached production deployment for "
f"\n🛑 Reached INT deployment for "
f"environment '{env_name}'"
)
self.print_summary(
"Stopped at production deployment"
"Stopped at INT deployment"
)
return True

# Auto-approve other environments
job_name = f"release_{env_name}"
if (job_name in self.jobs_requiring_approval and
job_name not in self.approved_jobs):
if (job_name in self.jobs_requiring_approval):
self.logger.info(
f"✓ Approving deployment to environment "
f"'{env_name}'..."
)
if self.approve_deployment(self.run_id, [env_id]):
self.approved_jobs.add(job_name)
self.logger.info(f"✅ Approved: {job_name}")
if job_name not in self.approved_jobs:
self.approved_jobs.add(job_name)
else:
self.logger.warning(f"⚠️ Failed to approve: {job_name}")

Expand Down
Loading