fix: FTRS-371 Add KMS key configuration for SNS topic encryption and …#1088
Merged
michal-jarecki merged 19 commits intomainfrom Apr 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds KMS encryption configuration for the Shield DDoS alerts SNS topic (via the Shield module) and updates related Terraform stacks and GitHub Actions workflow dependencies.
Changes:
- Add
kms_key_idinput to the Shield module and apply it to SNS topic encryption (kms_master_key_id). - Introduce
aws_kms_keylookups for the SNS KMS key in UI, read-only-viewer, and domain_name stacks and pass through to the Shield module. - Pin several GitHub Actions to commit SHAs and adjust the Allure installer download command.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| infrastructure/stacks/ui/shield.tf | Passes SNS KMS key ARN into Shield module. |
| infrastructure/stacks/ui/data.tf | Adds SNS KMS key data lookup (us-east-1) for UI stack. |
| infrastructure/stacks/read_only_viewer/shield.tf | Passes SNS KMS key ARN into Shield module. |
| infrastructure/stacks/read_only_viewer/data.tf | Adds SNS KMS key data lookup (us-east-1) for read-only-viewer stack. |
| infrastructure/stacks/domain_name/shield.tf | Passes SNS KMS key ARN into Shield module for Route53 protections. |
| infrastructure/stacks/domain_name/data.tf | Adds SNS KMS key data lookup (us-east-1) for domain_name stack. |
| infrastructure/modules/shield/variables.tf | Introduces kms_key_id module input. |
| infrastructure/modules/shield/sns.tf | Enables SNS topic encryption using kms_master_key_id. |
| .github/workflows/service-automation-test.yaml | Pins asdf actions to a commit SHA. |
| .github/workflows/quality-checks.yaml | Pins Checkov and asdf actions to commit SHAs. |
| .github/workflows/pipeline-truncate-workflow-history.yaml | Pins delete-workflow-runs action to a commit SHA. |
| .github/workflows/pipeline-deploy-architecture-pages.yaml | Pins likec4 action to a commit SHA. |
| .github/workflows/manage-dynamodb-data.yaml | Pins asdf actions to a commit SHA. |
| .github/workflows/build-sandbox-images.yaml | Pins asdf setup action to a commit SHA (also changes version). |
| .github/workflows/build-project.yaml | Pins asdf actions to a commit SHA. |
| .github/actions/install-allure/action.yaml | Adds wget redirect limit for Allure download. |
ri-nhs
previously approved these changes
Mar 27, 2026
mmg-nhse
reviewed
Mar 27, 2026
…rence in shield module
…ions configuration
… use environment input
timrickwood
approved these changes
Apr 2, 2026
mmg-nhse
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…update related modules
Description
Context
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.