Fix JSDoc options @param for model classes#299
Draft
colinrotherham wants to merge 9 commits into
Draft
Conversation
Collaborator
|
Can’t keep a good man down… thanks for this @colinrotherham 😄 |
Collaborator
Author
|
No worries @paulrobertlloyd 😊 Kinda looks like you need both
That way it's clear what you're working with at any given time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realised the JSDoc for model classes was in the wrong place so this PR moves them
It adds lots more red squiggles but they're finding lots of genuine things
E.g. Comparison of strings with booleans via
===(but the JSDoc could be wrong)