Skip to content

Fix JSDoc options @param for model classes#299

Draft
colinrotherham wants to merge 9 commits into
mainfrom
flash-types
Draft

Fix JSDoc options @param for model classes#299
colinrotherham wants to merge 9 commits into
mainfrom
flash-types

Conversation

@colinrotherham
Copy link
Copy Markdown
Collaborator

Realised the JSDoc for model classes was in the wrong place so this PR moves them

It adds lots more red squiggles but they're finding lots of genuine things

E.g. Comparison of strings with booleans via === (but the JSDoc could be wrong)

String to boolean comparison

@paulrobertlloyd paulrobertlloyd temporarily deployed to mavis-protot-flash-type-vkgwna May 15, 2026 15:49 Inactive
@paulrobertlloyd
Copy link
Copy Markdown
Collaborator

Can’t keep a good man down… thanks for this @colinrotherham 😄

@colinrotherham
Copy link
Copy Markdown
Collaborator Author

No worries @paulrobertlloyd 😊

Kinda looks like you need both Thing (class) and ThingModel types, where:

  • Dates are saved with string types in ThingModel as JSON data
  • Dates are passed with string types in ThingModel for class options
  • Dates are replaced with Date types in Thing as they become class instances

That way it's clear what you're working with at any given time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants