Skip to content

CCM-17641: reporting failure#345

Merged
nhsd-angel-pastor merged 5 commits into
mainfrom
feature/CCM-17641_reporting_failure
May 21, 2026
Merged

CCM-17641: reporting failure#345
nhsd-angel-pastor merged 5 commits into
mainfrom
feature/CCM-17641_reporting_failure

Conversation

@nhsd-angel-pastor
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor commented May 13, 2026

Description

  • Add error messages from the event DigitalLetterUnsuccessful in the reports to be sent to Trust.
  • Added scenario in component test to assert the error message appears.

See comment

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch from b1a99c8 to 8a9fef3 Compare May 13, 2026 16:33
@nhsd-angel-pastor nhsd-angel-pastor marked this pull request as ready for review May 14, 2026 08:00
@nhsd-angel-pastor nhsd-angel-pastor requested review from a team as code owners May 14, 2026 08:00
Comment thread .github/workflows/stage-3-build.yaml
Comment thread tests/pact-tests/package.json Outdated
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch from d8b880a to e31ed22 Compare May 14, 2026 12:32
Comment thread tests/playwright/helpers/event-builders.ts Outdated
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch 2 times, most recently from 5dfef2c to 1dc2d8e Compare May 14, 2026 16:01
@nhsd-angel-pastor nhsd-angel-pastor changed the title Feature/ccm 17641 reporting failure ccm-17641 reporting failure May 15, 2026
@nhsd-angel-pastor nhsd-angel-pastor changed the title ccm-17641 reporting failure CCM-17641: reporting failure May 15, 2026
tdroza-nhs
tdroza-nhs previously approved these changes May 15, 2026
Ian-Hodges
Ian-Hodges previously approved these changes May 15, 2026
Comment thread .gitleaksignore Outdated
Copy link
Copy Markdown
Contributor

@simonlabarere simonlabarere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that line from .gitleaksignore

@nhsd-angel-pastor nhsd-angel-pastor dismissed stale reviews from Ian-Hodges and tdroza-nhs via d4aa7df May 18, 2026 08:03
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch from afbf317 to d4aa7df Compare May 18, 2026 08:03
simonlabarere
simonlabarere previously approved these changes May 18, 2026
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch from d4aa7df to 7c9e875 Compare May 18, 2026 14:08
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch from 7c9e875 to f014956 Compare May 18, 2026 15:27
Comment thread .gitleaksignore
simonlabarere
simonlabarere previously approved these changes May 19, 2026
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-17641_reporting_failure branch from f014956 to 34ddd34 Compare May 20, 2026 10:06
@nhsd-angel-pastor nhsd-angel-pastor merged commit f8d053a into main May 21, 2026
35 checks passed
@nhsd-angel-pastor nhsd-angel-pastor deleted the feature/CCM-17641_reporting_failure branch May 21, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants