CCM-17993: Update MESHInboxMessageInvalid event#367
Open
ScottFullerton-NHSE wants to merge 3 commits into
Open
CCM-17993: Update MESHInboxMessageInvalid event#367ScottFullerton-NHSE wants to merge 3 commits into
ScottFullerton-NHSE wants to merge 3 commits into
Conversation
…ate-mesh-message-invalid-event
| $ref: ../defs/requests.schema.yaml#/properties/senderId | ||
| failureCode: | ||
| reasonCode: | ||
| $ref: ../defs/requests.schema.yaml#/properties/failureCode |
Contributor
There was a problem hiding this comment.
I wonder if it would be worth adding a reasonCode property to requests.schema.yaml. I don't think we can get rid of the failureCode type in requests.schema.yaml just yet as it might be used elsewhere.
Also there is a reasonCode in print.schema.yaml but we probably shouldn't use that either.
simonlabarere
approved these changes
May 21, 2026
Contributor
simonlabarere
left a comment
simonlabarere
left a comment
There was a problem hiding this comment.
I'm not sure why the ticket's scope wasn't to get rid of failureCode completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the MESHInboxMessageInvalid event to use reasonCode.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.