Open
Conversation
…view-from-message-plan
…view-from-message-plan
alexnuttall
changed the title
…view-from-message-plan
…view-from-message-plan
bhansell1
reviewed
Apr 7, 2026
| lockNumber, | ||
| }); | ||
| const backLinkHref = | ||
| hideBackLinks || lockNumber === undefined |
Contributor
There was a problem hiding this comment.
Is lockNumber === undefined because it's a submitted template?
bhansell1
reviewed
Apr 7, 2026
| <NotifyBackLink>{content.backLink.text}</NotifyBackLink> | ||
| </Link> | ||
| {backLinkHref && ( | ||
| <Link href={backLinkHref} passHref legacyBehavior> |
Contributor
There was a problem hiding this comment.
Could you use NHSNotifyBackLink?
bhansell1
reviewed
Apr 7, 2026
| @@ -0,0 +1,66 @@ | |||
| import { | |||
Contributor
There was a problem hiding this comment.
I don't think this component is a molecule it's closer to an organism or a template/page? What do you think?
bhansell1
reviewed
Apr 7, 2026
| await expect(templateBlock.defaultTemplateCard.templateName).toHaveText( | ||
| templates.AUTHORING_LETTER.name | ||
| ); | ||
| await expect(templateBlock.defaultTemplateCard.templateLink).toHaveText( |
Contributor
There was a problem hiding this comment.
Do you think its worth testing the opening in a new tab behaviour? Or that we have the correct attributes on the element?
bhansell1
reviewed
Apr 7, 2026
| rel="noopener noreferrer" | ||
| target="_blank" | ||
| > | ||
| Learn more |
bhansell1
reviewed
Apr 7, 2026
| it('matches snapshot without PDF file', () => { | ||
| const container = render( | ||
| <LetterRenderIframe tab='shortFormRender' pdfUrl={null} /> | ||
| <LetterRenderIframe renderType='shortFormRender' pdfUrl={null} /> |
Contributor
There was a problem hiding this comment.
Not an issue at all but I thought I'd just say - feel free to igore and resolve.
Given this rename from tab to renderType any benefit in changing shortFormRender to just short| long | initial?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
updated pages:
templates/message-plans/choose-standard-english-letter-template/b0b6ec01-721f-4580-8637-5920c5dbe0ca/preview-template/653bfc62-8ee2-419d-b0cd-ab19a237592c?lockNumber=1
templates/message-plans/choose-large-print-letter-template/b0b6ec01-721f-4580-8637-5920c5dbe0ca/preview-template/df460f0e-6af7-4c49-832f-fd80b7abdd91?lockNumber=1
templates/message-plans/review-and-move-to-production/a4ce1f87-5877-42e6-9019-92ebc7d6e13f
templates/message-plans/review-and-move-to-production/a4ce1f87-5877-42e6-9019-92ebc7d6e13f/preview-template/653bfc62-8ee2-419d-b0cd-ab19a237592c
templates/message-plans/preview-message-plan/a4ce1f87-5877-42e6-9019-92ebc7d6e13f
templates/message-plans/preview-message-plan/a4ce1f87-5877-42e6-9019-92ebc7d6e13f/preview-template/653bfc62-8ee2-419d-b0cd-ab19a237592c
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.