[PRM-666] REVERTED - Gone back to AWS SDK v1 due to extended client#316
Open
AndyFlintAnswerDigital wants to merge 1 commit intomainfrom
Open
[PRM-666] REVERTED - Gone back to AWS SDK v1 due to extended client#316AndyFlintAnswerDigital wants to merge 1 commit intomainfrom
AndyFlintAnswerDigital wants to merge 1 commit intomainfrom
Conversation
Code security issues foundView full details here. |
|
chrisbloe
reviewed
Mar 31, 2026
| public static SqsClient sqsClient(@Value("${localstack.url}") String localstackUrl) throws URISyntaxException { | ||
| return SqsClient.builder() | ||
| .credentialsProvider(() -> AwsBasicCredentials.create("LSIAQAAAAAAVNCBMPNSG", "LSIAQAAAAAAVNCBMPNSG")) | ||
| .credentialsProvider((()-> AwsBasicCredentials.create("LSIAQAAAAAAVNCBMPNSG", "LSIAQAAAAAAVNCBMPNSG"))) |
Contributor
There was a problem hiding this comment.
Does this need an extra bracket?
chrisbloe
reviewed
Mar 31, 2026
| PublishResponse response = snsClient.publish(request); | ||
| String[] topicAttributes = topicArn.split(":"); | ||
| log.info("PUBLISHED: message to {} topic. Published SNS message id: {}", topicAttributes[topicAttributes.length - 1], response.messageId()); | ||
| var result = snsClient.publish(request); |
chrisbloe
reviewed
Mar 31, 2026
|
|
||
| @Bean | ||
| public AmazonSNSExtendedClient s3SupportedSnsClient(AmazonSNS snsClient, AmazonS3 s3) { | ||
| var snsExtendedClientConfiguration = new SNSExtendedClientConfiguration() |
chrisbloe
reviewed
Mar 31, 2026
|
|
||
| @Bean | ||
| public AmazonSQSExtendedClient s3SupportedSqsClient(AmazonSQSAsync sqsClient, AmazonS3 s3) { | ||
| var extendedClientConfiguration = new ExtendedClientConfiguration().withPayloadSupportEnabled(s3, bucketName, true); |
chrisbloe
reviewed
Mar 31, 2026
|
|
||
| @Bean | ||
| public SQSConnection createConnection(AmazonSQSAsync amazonSQSAsync) throws JMSException { | ||
| var connectionFactory = new SQSConnectionFactory(new ProviderConfiguration(), amazonSQSAsync); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.