VIA 685: NextJS and Node version upgrade

.env.template

@@ -44,6 +44,7 @@ AUTH_SECRET=some-random-secret-works
 # Playwright tests
 TEST_APP_URL=https://localhost:3000/check-and-book-vaccinations
 TEST_NHS_APP_URL=https://<fake-sso-app>/auth/login?vita=https://localhost:3000
+USE_FAKE_AUTH=false
 TEST_NHS_APP_USERNAME=
 TEST_NHS_APP_PASSWORD=
 TEST_NBS_APP_USERNAME=

.github/dependabot.yaml

@@ -32,10 +32,6 @@ updates:
       prettier:
         patterns: [ "prettier", "prettier*", "*prettier", "*prettier*" ]
     ignore:
-      - dependency-name: "next"
-        versions: [ ">=16.0.0" ]
-      - dependency-name: "eslint-config-next"
-        versions: [ ">=16.0.0" ]
       - dependency-name: "eslint"
         versions: [ ">=10.0.0" ]
     cooldown:

.tool-versions

@@ -3,7 +3,7 @@
 terraform 1.14.1
 pre-commit 4.5.0
 vale 3.13.0
-nodejs 22.13.1
+nodejs 24.14.0
 
 # ==============================================================================
 # The section below is reserved for Docker image versions.

e2e/auth.ts

@@ -31,7 +31,8 @@ export const login = async (browser: Browser, nhsLoginUsername: string): Promise
   const user = loadUserFromEnvironment(nhsLoginUsername);
   let page;
 
-  const useFakeAuth = user.nhsAppLoginUrl.endsWith("localhost:3000");
+  const useFakeAuth =
+    user.nhsAppLoginUrl.endsWith("localhost:3000") || process.env["TEST_USE_FAKE_AUTH"]?.toLowerCase() === "true";
   if (useFakeAuth) {
     const fakeAuthConfig = loadFakeAuthEnvironmentVariables();
     const context = await browser.newContext({

esbuild.config.mjs

@@ -31,7 +31,7 @@ const buildLambda = async () => {
     minify: true,
     platform: "node",
     jsx: "automatic",
-    target: "node22",
+    target: "node24",
     external: ["./xhr-sync-worker.js"],
     outfile: `${OUTPUT_DIR}/lambda.js`,
   });

eslint.config.mjs

@@ -1,14 +1,10 @@
-import { FlatCompat } from "@eslint/eslintrc";
+import tsPlugin from "@typescript-eslint/eslint-plugin";
+import typescriptParser from "@typescript-eslint/parser";
+import nextCoreWebVitals from "eslint-config-next/core-web-vitals";
+import nextTypescript from "eslint-config-next/typescript";
+import prettierConfig from "eslint-config-prettier";
 import compat_plugin from "eslint-plugin-compat";
-import { dirname } from "path";
-import { fileURLToPath } from "url";
-
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-});
+import globals from "globals";
 
 const eslintConfig = [
   {
@@ -29,36 +25,97 @@ const eslintConfig = [
       "performance/report",
     ],
   },
-  ...compat.extends("next/core-web-vitals", "next/typescript", "prettier", "next"),
-  compat_plugin.configs["flat/recommended"],
+  ...nextCoreWebVitals,
+  ...nextTypescript,
+  prettierConfig,
+
+  // ----------------------------
+  // APPLICATION CODE (TS/JS/React)
+  // ----------------------------
   {
+    files: ["**/*.{js,jsx,ts,tsx}"],
+    languageOptions: {
+      parser: typescriptParser,
+      parserOptions: {
+        sourceType: "module",
+        ecmaFeatures: { jsx: true },
+      },
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+      },
+    },
+    plugins: {
+      "@typescript-eslint": tsPlugin,
+      compat: compat_plugin,
+    },
     rules: {
       "@typescript-eslint/no-unused-vars": "error",
-
-      // nhsuk-frontend: https://github.com/nhsuk/nhsuk-frontend/blob/main/docs/contributing/browser-support.md
-      // Ref: https://github.com/nhsuk/nhsuk-frontend/blob/main/packages/nhsuk-frontend/.browserslistrc
-      // supported browsers are listed in package.json
       "compat/compat": "warn",
     },
   },
 
+  // Node-only files
+  {
+    files: ["*.config.mjs", "*.config.ts", "*.setup.ts", "esbuild.config.mjs"],
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+
   // Type-aware rules
   {
     files: ["**/*.{ts,tsx}"],
     languageOptions: {
       parserOptions: {
         project: true,
-        tsconfigRootDir: __dirname,
       },
     },
     rules: {
       "@typescript-eslint/no-floating-promises": "error",
     },
   },
 
-  // Override for test files: turn off compat
+  // ----------------------------
+  // TEST FILES
+  // ----------------------------
+
   {
     files: ["**/*.test.{js,jsx,ts,tsx}", "**/*.spec.{js,jsx,ts,tsx}", "test-data/**"],
+    languageOptions: {
+      parser: typescriptParser,
+      parserOptions: {
+        ecmaVersion: "latest",
+        sourceType: "module",
+        ecmaFeatures: { jsx: true },
+      },
+      globals: {
+        ...globals.jest,
+        ...globals.node,
+        ...globals.browser,
+      },
+    },
+    plugins: {
+      compat: compat_plugin,
+    },
+    rules: {
+      "compat/compat": "off",
+    },
+  },
+  // Override for server-only files: browser compat is irrelevant for code that runs in Node.js
+  {
+    files: [
+      "src/_lambda/**",
+      "src/app/api/**",
+      "src/services/**",
+      "src/utils/auth/apim/**",
+      "src/utils/auth/callbacks/**",
+      "src/utils/auth/generate-auth-payload.ts",
+      "src/utils/auth/get-jwt-token.ts",
+      "src/utils/auth/pem-to-crypto-key.ts",
+    ],
     rules: {
       "compat/compat": "off",
     },

infrastructure/environments/dev/locals.tf

@@ -11,7 +11,7 @@ locals {
   deploy_workspace          = var.is_github_action ? "gh" : terraform.workspace
   prefix                    = "${local.deploy_workspace}-${local.project_identifier_shortcode}-${data.aws_caller_identity.current.account_id}"
   open_next_path            = "../../../.open-next"
-  node_version              = "nodejs22.x"
+  node_version              = "nodejs24.x"
   log_retention_in_days     = 7
   cache_lambda_zip_path     = "../../../lambda.zip"
   content_cache_bucket_name = "${local.prefix}-content-cache"

infrastructure/environments/preprod/locals.tf

@@ -11,7 +11,7 @@ locals {
   deploy_workspace          = var.is_github_action ? "gh" : terraform.workspace
   prefix                    = "${local.deploy_workspace}-${local.project_identifier_shortcode}-${data.aws_caller_identity.current.account_id}"
   open_next_path            = "../../../.open-next"
-  node_version              = "nodejs22.x"
+  node_version              = "nodejs24.x"
   log_retention_in_days     = 30
   cache_lambda_zip_path     = "../../../lambda.zip"
   content_cache_bucket_name = "${local.prefix}-content-cache"

infrastructure/environments/prod/locals.tf

@@ -11,7 +11,7 @@ locals {
   deploy_workspace          = var.is_github_action ? "gh" : terraform.workspace
   prefix                    = "${local.deploy_workspace}-${local.project_identifier_shortcode}-${data.aws_caller_identity.current.account_id}"
   open_next_path            = "../../../.open-next"
-  node_version              = "nodejs22.x"
+  node_version              = "nodejs24.x"
   log_retention_in_days     = 30
   cache_lambda_zip_path     = "../../../lambda.zip"
   content_cache_bucket_name = "${local.prefix}-content-cache"

infrastructure/environments/test/locals.tf

@@ -11,7 +11,7 @@ locals {
   deploy_workspace          = var.is_github_action ? "gh" : terraform.workspace
   prefix                    = "${local.deploy_workspace}-${local.project_identifier_shortcode}-${data.aws_caller_identity.current.account_id}"
   open_next_path            = "../../../.open-next"
-  node_version              = "nodejs22.x"
+  node_version              = "nodejs24.x"
   log_retention_in_days     = 30
   cache_lambda_zip_path     = "../../../lambda.zip"
   content_cache_bucket_name = "${local.prefix}-content-cache"

infrastructure/modules/deploy_app/variables.tf

@@ -10,7 +10,7 @@ variable "prefix" {
 
 variable "nodejs_version" {
   type        = string
-  description = "Version of the nodejs to use, e.g. 'nodejs22.x'"
+  description = "Version of the nodejs to use, e.g. 'nodejs24.x'"
 }
 
 variable "open-next-path" {

infrastructure/modules/deploy_lambda/variables.tf

@@ -15,7 +15,7 @@ variable "region" {
 
 variable "nodejs_version" {
   type        = string
-  description = "Version of the nodejs to use, e.g. 'nodejs22.x'"
+  description = "Version of the nodejs to use, e.g. 'nodejs24.x'"
 }
 
 variable "default_tags" {

jest.setup.ts

@@ -1,5 +1,22 @@
 import "@testing-library/jest-dom";
+import { performance as nodePerf } from "perf_hooks";
 import { TextDecoder, TextEncoder } from "util";
 
 global.TextEncoder = TextEncoder;
 global.TextDecoder = TextDecoder;
+
+if (typeof globalThis.performance.mark !== "function") {
+  Object.defineProperty(globalThis.performance, "mark", {
+    value: nodePerf.mark.bind(nodePerf),
+    configurable: true,
+    writable: true,
+  });
+}
+
+if (typeof globalThis.performance.measure !== "function") {
+  Object.defineProperty(globalThis.performance, "measure", {
+    value: nodePerf.measure.bind(nodePerf),
+    configurable: true,
+    writable: true,
+  });
+}