You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
NPA-6615: bump OAS version to 1.20.0 for release (#338)
# Pull Request
## 🧾 Ticket Link
<!-- Add the Jira ticket link here -->
https://nhsd-jira.digital.nhs.uk/browse/NPA-6615
---
## 📄 Description/Summary of Changes
<!-- Describe the changes made in this PR. Include the
purpose/scope/impact of the changes -->
- Spec version bump for the release
---
## 🧪 Developer Testing Carried Out
<!-- Describe what tests (automated/unit/manual etc.) have been done for
the ticket. Include: -->
<!-- - Any tests added/updated -->
<!-- - Evidence that each acceptance criterion from the Jira ticket is
met -->
<!-- - Evidence of tests running eg. link to github workflow with tests
passing or screenshot of tests running locally -->
- <!-- Briefly describe the testing carried out in this PR -->
---
## 📋 PR Principles
<!-- Principles we as a team follow when conducting a PR -->
- Keep PRs Small and Focused: Ensure the PR addresses a single task or
feature to make it easier to review.
- Multiple PRs for one Ticket: When splitting work into multiple PRs,
clearly describe what this PR addresses and outline the remaining work
to complete the ticket.
- Ensure Tests Are Included: Add or update unit, integration, or
end-to-end tests to cover the changes made.
- Follow Coding Standards: Ensure the code adheres to the team's coding
guidelines and best practices.
- Resolve Comments Promptly: If you raise a comment, ensure you follow
up and resolve it before approving the PR to maintain clarity and ensure
comments are addressed.
- Foster Learning: PR reviews are an opportunity to share knowledge,
provide constructive feedback, and encourage a collaborative
environment.
## 🏷️ Naming Conventions Reminder
Please ensure the following naming conventions are followed:
- PR title follows the format: `NPA-XXXX: <short-description>`
- Branch name follows the convention:
`<type>/NPA-XXXX/<short-description>`
- Commit messages follow the template: `NPA-XXXX: <short-description>`