adding -Wno-c++20-compat flag to CMakeLists.txt#18
Open
jdnixx wants to merge 1 commit intoNICHOLAS85:masterfrom
Open
adding -Wno-c++20-compat flag to CMakeLists.txt#18jdnixx wants to merge 1 commit intoNICHOLAS85:masterfrom
jdnixx wants to merge 1 commit intoNICHOLAS85:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(on Kubuntu 23.10) compilation fails at the
make -j$(nproc)step with a bunch of warningsAdding the -Wno-c++20-compat flag resolves it & lets it compile. Note this is only after the changes to cpptoml and cxxopts files with
#include <limits>as you said in #17 , so that will have to be addressed too for it to compile out of the box, but I found even after doing that the compatibility thing prevented me from building.