Skip to content

Replace broken links#693

Merged
sjvrijn merged 1 commit intomainfrom
686-fix-guide-links
Sep 8, 2025
Merged

Replace broken links#693
sjvrijn merged 1 commit intomainfrom
686-fix-guide-links

Conversation

@sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Sep 7, 2025

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] All user facing changes have been added to CHANGELOG.md

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

Refs:

Describe the changes made in this pull request

Wherever possible, old links to the guide have been replaced by updated working ones.
Those links for which the content is no longer on the guide, I've replaced them with links to the Turing Way instead.
Only for the NOTICE file was even this not possible, so I linked to the documentation on apache.org instead. Not quite happy with this one though, so better suggestions are more than welcome!

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package

Create a local git repo to push to GitHub to trigger CI actions

git init
git add --all
git commit -m "First commit"
git remote add origin git@github.com:<YOU>/python-template-test.git
git push -u origin main -f

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjvrijn sjvrijn force-pushed the 686-fix-guide-links branch from 81a6f95 to 840b313 Compare September 8, 2025 08:20
@sjvrijn sjvrijn merged commit c4a6555 into main Sep 8, 2025
18 checks passed
@sjvrijn sjvrijn deleted the 686-fix-guide-links branch September 8, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants