change sonarcloud action to sonarqube

[sjvrijn]

Checklist before requesting a review

• I have read the contribution guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• [ ] All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests

Refs:

• Sonar action deprecated #691

Describe the changes made in this pull request

Changed the sonarcloud-github-action to sonarqube-scan-action. Since the name 'sonarcloud' is still in use, no further changes seem to be necessary for consistency.

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package

Create a local git repo to push to GitHub to trigger CI actions

git init
git add --all
git commit -m "First commit"
git remote add origin git@github.com:<YOU>/python-template-test.git
git push -u origin main -f

[sverhoeven]

Change should work according to sonars docs.

The docs of the new action do not mention GITHUB_TOKEN env var, so it could be removed. Most likely getting PR info is now handled via SonarQubeCloud integration app.

[sjvrijn]

Change should work according to sonars docs.

The docs of the new action do not mention GITHUB_TOKEN env var, so it could be removed. Most likely getting PR info is now handled via SonarQubeCloud integration app.

Good catch, I'll remove it, then merge