Conversation
This was referenced May 22, 2025
Closed
Member
Author
|
I have now added capturing back in. Turns out there are things in X.509 (like, say, The mechanism works in principle but hasn’t been tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR redesigns nearly all aspects of bcder. Its original aim was to make the crate panic-free but in the process I decided to redesign the whole API around byte slices rather than using
Bytes.The decoding part now doesn’t rely on closures any more but those methods are still provided since closures may actually convenient. We’ve renamed the methods in an attempt to create a better naming scheme. The old names are still provided for easier transition.
This PR currently does not include the old capturing mechanism. I am kind of hoping we can get away without this mechanism. If you do need it, please let me know. We are currently using it in rpki-rs, so I’ll likely also discover if we can’t get away without it.This PR is most definitely a breaking change.
This PR is definitely still in draft status. Here’s a list of things still need to be done:
Primitiveif the underlying source already has the complete data,get_uncheckedwhich is what it is.There is probably more.