Fix Integer::is_zero to check entire value#94
Closed
sumleo wants to merge 2 commits intoNLnetLabs:mainfrom
Closed
Conversation
Previously only checked first byte, incorrectly returning true for multi-byte positive integers starting with 0x00 (e.g., 128u8 encodes as [0x00, 0x80] but is not zero). Now checks that the value is exactly one byte containing zero.
Member
|
In BER encoding, multi-byte integers are not allowed to have the bits of the first octet be all zero or all one, i.e., they need to be encoded with the shortest possible number of octets. This is enforced by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect is_zero() implementation that only checked the first byte, returning true for non-zero multi-byte integers starting with 0x00. Now correctly checks for single-byte zero.