Skip to content

fix: fix-generate-lockfile #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pablo-garay wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fix-generate-lockfile #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ecb2c
fix-generate-lockfile
pablo-garay Nov 14, 2025
b709f39
Add 'accelerate' dependency to pyproject.toml
abhinavg4 Nov 13, 2025
c300eb2
Update uv.lock
github-actions[bot] Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/generate-lockfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
token: ${{ secrets.PAT }}
Copy link
Collaborator

@chtruong814 chtruong814 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need a PAT?

Copy link
Contributor Author

@pablo-garay pablo-garay Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because with github_token by Github rules the auto-commit disables the GHA CI automatic checks after. This is why needed to add this line change. We want GHA CI checks to run after the uv lock file autocommit. Otherwise the users cannot merge and need to get it unstuck (reset soft + re-commit with user name) which users do not have a clue about

Copy link
Collaborator

@chtruong814 chtruong814 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this similar workflow not need it?
https://github.com/NVIDIA-NeMo/Automodel/blob/main/.github/workflows/uv-lock-generation.yml

Here's an example of it working.
NVIDIA-NeMo/Automodel#776


- name: Generate lockfile in NGC container
run: |
Expand Down Expand Up @@ -96,7 +97,7 @@ jobs:
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"
git add uv.lock
git commit -m "Update uv.lock [skip ci]"
git commit -m "Update uv.lock"
git push origin HEAD:${{ github.ref_name }}

- name: Comment on PR with lockfile status
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ classifiers = [
"Topic :: Utilities",
]
dependencies = [
"accelerate",
"diffusers==0.35.1",
"easydict",
"ftfy",
Expand Down
20 changes: 20 additions & 0 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading