switch PythonTool from stdio to persistent HTTP server#1228
Draft
gwarmstrong wants to merge 3 commits intomainfrom
Draft
switch PythonTool from stdio to persistent HTTP server#1228gwarmstrong wants to merge 3 commits intomainfrom
gwarmstrong wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: George Armstrong <georgea@nvidia.com>
gwarmstrong
force-pushed
the
georgea/python-tool-http-server
branch
from
8845c41 to
cfe2fd5
Compare
…Error ref The hydra init_hook assumes MCPStdioClient (accesses client.server_params) but PythonTool now uses MCPStreamableHttpClient which doesn't have that attribute. The sandbox config is already handled in post_configure() which spawns the HTTP server subprocess with --config flag. Also fix bare RemoteProtocolError reference (should be httpx.RemoteProtocolError). Signed-off-by: George Armstrong <georgea@nvidia.com>
Rename DirectPythonTool (direct sandbox calls) to PythonTool since it is the simpler, more reliable default for generation. The MCP subprocess variant is now MCPPythonTool (for Gym/RL resource server use). DirectPythonTool kept as backward-compatible alias. Signed-off-by: George Armstrong <georgea@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.