Skip to content

Improve docs for GA#230

Merged
jiwenc-nv merged 15 commits intomainfrom
jiwenc/docs-quickstart
Mar 10, 2026
Merged

Improve docs for GA#230
jiwenc-nv merged 15 commits intomainfrom
jiwenc/docs-quickstart

Conversation

@jiwenc-nv
Copy link
Collaborator

@jiwenc-nv jiwenc-nv commented Mar 9, 2026

Summary by CodeRabbit

  • New Features

    • Added a declarative TeleopSession API guide and new Device/Tracker documentation with examples.
  • Documentation

    • Reworked Quick Start toward CloudXR, added build-from-source and system requirements, expanded retargeting and ecosystem references, added device/trackers how‑tos, and removed several legacy example READMEs and an old run script.
  • Style

    • Updated docs styling and external-link behavior for improved readability.

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Reworks and expands documentation across device plugins, trackers, TeleopSession API, getting-started and build-from-source guides; adds Sphinx roles and link behavior; adjusts CSS; removes several README files and an Isaac Lab run script; updates examples and retargeting docs and index toctrees.

Changes

Cohort / File(s) Summary
Top-level docs & README
README.md
Bumped Isaac Lab badge, consolidated key features and teleoperation guidance into external documentation links; removed in-page detailed setup and CloudXR-specific steps.
Sphinx config & styling
docs/source/conf.py, docs/source/_static/css/custom.css
Added GitHub-linked code/file roles; make external http(s) links open in new tabs and inject rel attributes; adjusted inline code and link styling.
Device subsystem docs (new)
docs/source/device/index.rst, docs/source/device/trackers.rst, docs/source/device/add_device.rst
Added Device Interface overview, Tracker API, and step-by-step guide for adding devices (FlatBuffers schema, plugin, tracker, examples).
Getting started / TeleopSession
docs/source/getting_started/quick_start.rst, docs/source/getting_started/teleop_session.rst, docs/source/getting_started/build_from_source.rst
Rewrote Quick Start to a CloudXR-centered workflow; introduced TeleopSession declarative API docs and build-from-source guidance including CloudXR pre-download/override instructions.
Retargeting & ecosystem
docs/source/references/retargeting.rst, docs/source/overview/ecosystem.rst
Expanded retargeting docs with new Source nodes, richer retargeter configs/examples and import path fixes; replaced ecosystem placeholder with device support and planned devices tables.
Examples & README removals/updates
examples/schemaio/CMakeLists.txt, examples/schemaio/README.md, examples/teleop_session_manager/python/README.md, src/core/teleop_session_manager/README.md
Removed examples/schemaio/README.md and its install target; deleted TeleopSessionManager README; updated example README links to point at new TeleopSession docs.
Scripts removed
scripts/run_isaac_lab.sh
Deleted Isaac Lab runner script (preflight checks, env sourcing, Isaac Lab invocation removed).
References & index updates
docs/source/index.rst, docs/source/references/device.rst, docs/source/references/requirements.rst
Adjusted toctrees to include TeleopSession and device index; removed old Device Interface content; added a new System Requirements page.
Examples (schemaio)
examples/schemaio/CMakeLists.txt
Updated copyright year and removed install(FILES README.md ...) target.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant User
participant TeleopSession
participant DeviceIOSession
participant Tracker
participant Environment
User->>TeleopSession: create(session_config)
TeleopSession->>DeviceIOSession: open sources/plugins
DeviceIOSession->>Tracker: register/update per-frame
loop per frame
TeleopSession->>Tracker: step(elapsed_time)
Tracker->>DeviceIOSession: push/publish tensor data
DeviceIOSession->>Environment: deliver inputs/actions
Environment->>TeleopSession: state/feedback
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 I hopped through docs with eager paws,

Trackers, schemas, links and laws,
New sessions hum, old scripts take flight,
Pages trimmed to tidy light,
A happy hop—documentation bright.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Improve docs for GA' is vague and generic, using non-descriptive terms that don't convey meaningful information about the specific documentation changes made. Replace with a more specific title that describes the primary documentation changes, such as 'Reorganize device and teleoperation documentation' or 'Consolidate README and update device/retargeting docs'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jiwenc/docs-quickstart

Comment @coderabbitai help to get the list of available commands and usage tips.

@jiwenc-nv jiwenc-nv force-pushed the jiwenc/docs-quickstart branch 2 times, most recently from 9abec13 to 609b221 Compare March 9, 2026 02:01
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/source/_static/css/custom.css`:
- Around line 68-75: The global removal of underlines on the a selector harms
accessibility; change the rule so it only targets navigation or decorative links
(e.g., replace the global a selector with a more specific selector such as nav a
or a.no-underline) and retain underlines for body text links, and ensure focus
styles remain highly visible (keep a:focus and a:hover underline or an
equivalent visible focus indicator for keyboard users) so functions like the a,
a:hover, a:focus selectors are adjusted accordingly.

In `@docs/source/device/add_device.rst`:
- Around line 142-143: The cross-reference direction is wrong: change the phrase
that reads ":ref:`Schema IO example: build and run <schema-io-example>` above
for building and running ``pedal_pusher`` and ``pedal_printer``." to say "below"
instead of "above" so the sentence correctly references the :ref: target
"schema-io-example" which is defined below; update the text containing the
literal strings "schema-io-example", "pedal_pusher", and "pedal_printer"
accordingly.

In `@docs/source/device/trackers.rst`:
- Around line 33-38: Fix the typos in the documentation note: change
"considerred" to "considered" and "practive" to "practice" in the sentence
referencing the DeviceIOSession and the :doc:`../getting_started/teleop_session`
so the note reads that DeviceIOSession is considered a low level API and in
practice it is recommended to use the teleop_session to manage a teleop session
with multiple device trackers and retargeters.

In `@docs/source/getting_started/quick_start.rst`:
- Line 99: Fix the typo in the documentation string "or insetall a separate
client." by replacing "insetall" with "install" so the sentence reads "or
install a separate client."; locate the exact phrase "or insetall a separate
client." in the quick start doc and update it to "or install a separate client."
- Line 210: The file ends without a trailing newline which breaks the
end-of-file-fixer hook; open the docs/source/getting_started/quick_start.rst and
add a single newline at the end of the file (after the line containing the link
label "`CloudXR teleoperation in Isaac Lab`:
https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html")
so the file ends with a newline character.
- Around line 123-126: Remove the duplicated sentence "for more details if you
want to run the web client from source" in the quick start doc: keep a single
instance of that clause (immediately after the CloudXR.js documentation
reference) and delete the redundant repeat so the paragraph reads once,
preserving surrounding punctuation and capitalization.

In `@docs/source/references/retargeting.rst`:
- Around line 124-126: Replace the hard-coded GitHub URL that uses "blob/main"
(e.g. the string
"https://github.com/NVIDIA/IsaacTeleop/blob/main/src/retargeters/README.md"
referenced in this file) with either a relative/local docs page link or a
branch/tag-aware URL (for example using the release tag placeholder or a
variable that the docs build injects) so the referenced example stays
version-locked to the docs; update each occurrence (the three links currently
pointing to blob/main) to use the chosen approach and ensure the link target
exists in the docs or repository for that release.

In `@examples/teleop_session_manager/python/README.md`:
- Line 39: Update the README.md documentation reference: replace the incorrect
path string "docs/source/references/teleop_session.rst" with the correct module
doc path "docs/source/getting_started/teleop_session.rst" so the README points
to the actual teleop_session documentation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 11de9ac1-0479-4999-9b1f-2c804c67bc83

📥 Commits

Reviewing files that changed from the base of the PR and between 904f15b and 9abec13.

⛔ Files ignored due to path filters (1)
  • docs/source/_static/cloudxr-web-client-howto.png is excluded by !**/*.png
📒 Files selected for processing (16)
  • README.md
  • docs/source/_static/css/custom.css
  • docs/source/conf.py
  • docs/source/device/add_device.rst
  • docs/source/device/index.rst
  • docs/source/device/trackers.rst
  • docs/source/getting_started/quick_start.rst
  • docs/source/getting_started/teleop_session.rst
  • docs/source/index.rst
  • docs/source/overview/ecosystem.rst
  • docs/source/references/device.rst
  • docs/source/references/retargeting.rst
  • examples/schemaio/CMakeLists.txt
  • examples/schemaio/README.md
  • examples/teleop_session_manager/python/README.md
  • src/core/teleop_session_manager/README.md
💤 Files with no reviewable changes (4)
  • src/core/teleop_session_manager/README.md
  • docs/source/references/device.rst
  • examples/schemaio/README.md
  • README.md

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (3)
docs/source/getting_started/quick_start.rst (3)

123-125: ⚠️ Potential issue | 🟡 Minor

Remove duplicate sentence fragment.

Lines 124-125 repeat the phrase "for more details if you want to run the web client from source."

📝 Proposed fix
 The source code for the web client is in the :code-dir:`deps/cloudxr/webxr_client/` directory. Follow
-the instructions in the official `CloudXR.js documentation`_ for more details if you want to run the web client from source.
-for more details if you want to run the web client from source.
+the instructions in the official `CloudXR.js documentation`_ for more details if you want to run the web client from source.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` around lines 123 - 125, Remove
the duplicated sentence fragment "for more details if you want to run the web
client from source." from the quick start paragraph so it appears only once;
locate the paragraph that mentions ":code-dir:`deps/cloudxr/webxr_client/`" and
the CloudXR.js documentation and delete the repeated trailing phrase so the
sentence reads cleanly without repetition.

99-99: ⚠️ Potential issue | 🟡 Minor

Fix typo: "insetall" → "install".

The typo from the previous review remains unfixed.

📝 Proposed fix
-or insetall a separate client.
+or install a separate client.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 99, Replace the
misspelled word "insetall" with "install" in the sentence containing the phrase
"or insetall a separate client." so it reads "or install a separate client.";
update the single occurrence in the quick start docs entry to correct the typo.

210-210: ⚠️ Potential issue | 🟡 Minor

Add missing newline at end of file.

The pipeline failure from the previous review indicated this file is missing a trailing newline, which is required by the end-of-file-fixer pre-commit hook.

📝 Proposed fix
 .. _`CloudXR teleoperation in Isaac Lab`: https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html
+
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 210, The file ends with
the line ".. _`CloudXR teleoperation in Isaac Lab`:
https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html"
but is missing a trailing newline; open the file containing that anchor line and
add a single newline character at the end of file so the `end-of-file-fixer`
pre-commit hook passes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@docs/source/getting_started/quick_start.rst`:
- Around line 123-125: Remove the duplicated sentence fragment "for more details
if you want to run the web client from source." from the quick start paragraph
so it appears only once; locate the paragraph that mentions
":code-dir:`deps/cloudxr/webxr_client/`" and the CloudXR.js documentation and
delete the repeated trailing phrase so the sentence reads cleanly without
repetition.
- Line 99: Replace the misspelled word "insetall" with "install" in the sentence
containing the phrase "or insetall a separate client." so it reads "or install a
separate client."; update the single occurrence in the quick start docs entry to
correct the typo.
- Line 210: The file ends with the line ".. _`CloudXR teleoperation in Isaac
Lab`:
https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html"
but is missing a trailing newline; open the file containing that anchor line and
add a single newline character at the end of file so the `end-of-file-fixer`
pre-commit hook passes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f97e2926-9a30-481b-8a2c-d961881286a4

📥 Commits

Reviewing files that changed from the base of the PR and between 9abec13 and 609b221.

⛔ Files ignored due to path filters (1)
  • docs/source/_static/cloudxr-web-client-howto.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • docs/source/getting_started/quick_start.rst

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/source/getting_started/quick_start.rst`:
- Around line 106-107: Correct the typo "Vision Pro cilent" to "Vision Pro
client" in the Quick Start text that references `CloudXR network setup`; update
the wording in the sentence mentioning running the CloudXR runtime and wss proxy
in containerized environments or using the Vision Pro client so the term
"client" is spelled correctly.
- Around line 117-120: Update the wording in the sentence that currently reads
"You can just open this URL in your headset's browser to connect to your
headset" so it correctly states that the headset browser connects to the
workstation running CloudXR (e.g., "to connect the headset to the workstation
running CloudXR"); also fix the typo "insetall" to "install" in the same
paragraph. Locate and edit the sentence in the quick_start.rst paragraph that
references the hosted CloudXR client URL (nvidia.github.io/IsaacTeleop/client)
to make these wording and spelling corrections.

In `@docs/source/overview/ecosystem.rst`:
- Around line 64-75: Replace the hardcoded "Q2 2026" ETA in the "Planned Input
Devices" list-table: locate the table titled "Planned Input Devices" and the row
with "Keyboard and Mouse" and change the ETA cell to a non-timebound value such
as "TBD" or "Planned" (or replace it with a link to a maintainable roadmap page)
so the docs don't contain a stale fixed date.
- Around line 82-84: The three external links labeled "Manus Gloves Plugin",
"Generic 3-axis Pedal Plugin", and "OAK-D Camera Plugin" use hardcoded tree/main
URLs which are not version-stable; update each link in ecosystem.rst to use
either a Sphinx internal reference (e.g., :ref:`manus-gloves-plugin` or the
appropriate doc page name) or a version-aware source link (pointing to a
release/tag instead of tree/main or using a build variable that inserts the
current docs version), replacing the existing URLs so published docs always
reference the correct versioned plugin paths.

In `@README.md`:
- Around line 135-137: Fix the broken handoff paragraph by correcting the typos
and completing the trailing sentence: replace "Isaac Tepeop Core is design" with
"Isaac Tepeop Core is designed" and ensure the second sentence reads something
like "Then follow the CloudXR teleoperation in Isaac Lab guide to get started
with teleoperation." Update the fragment "Teleoperation in ." to a complete
phrase ("teleoperation" or "teleoperation in Isaac Lab") and verify the link
text around "CloudXR teleoperation in Isaac Lab" remains intact and points to
the provided URL.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 23113417-bfe7-43c8-b7d1-b780d575c46c

📥 Commits

Reviewing files that changed from the base of the PR and between 609b221 and 7b0fa9c.

⛔ Files ignored due to path filters (1)
  • docs/source/_static/cloudxr-web-client-howto.png is excluded by !**/*.png
📒 Files selected for processing (5)
  • README.md
  • docs/source/getting_started/build_from_source.rst
  • docs/source/getting_started/quick_start.rst
  • docs/source/overview/ecosystem.rst
  • scripts/run_isaac_lab.sh
💤 Files with no reviewable changes (1)
  • scripts/run_isaac_lab.sh

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (5)
docs/source/getting_started/quick_start.rst (4)

133-134: ⚠️ Potential issue | 🟡 Minor

Fix confusing wording and typo.

Line 133 incorrectly states the headset connects "to your headset" when it should say it connects to the workstation. Line 134 contains the typo "insetall" instead of "install".

📝 Proposed fix
-You can just open this URL in your headset's browser to connect to your headset. No need to build
-or insetall a separate client.
+You can just open this URL in your headset's browser to connect to the workstation running CloudXR. No need to build
+or install a separate client.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` around lines 133 - 134, Update
the sentence containing "open this URL in your headset's browser to connect to
your headset" to clarify that the headset connects to the workstation (e.g.,
replace "to your headset" with "to the workstation"), and correct the typo
"insetall" to "install" in the same paragraph (search for the fragment "open
this URL in your headset's browser" to locate the text).

121-121: ⚠️ Potential issue | 🟡 Minor

Fix typo: "cilent" → "client".

Line 121 contains a typo in "Vision Pro cilent".

📝 Proposed fix
-running the CloudXR runtime and wss proxy in containerized environment; or using Vision Pro cilent).
+running the CloudXR runtime and wss proxy in containerized environment; or using Vision Pro client).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 121, Fix the typo
"Vision Pro cilent" by replacing "cilent" with "client" wherever it appears
(specifically update the sentence containing "Vision Pro cilent" in the quick
start text), e.g., change "Vision Pro cilent" to "Vision Pro client" to correct
the spelling in the documentation string.

159-160: ⚠️ Potential issue | 🟡 Minor

Remove duplicate sentence.

The phrase "for more details if you want to run the web client from source" appears twice consecutively.

📝 Proposed fix
 The source code for the web client is in the :code-dir:`deps/cloudxr/webxr_client/` directory. Follow
-the instructions in the official `CloudXR.js documentation`_ for more details if you want to run the web client from source.
-for more details if you want to run the web client from source.
+the instructions in the official `CloudXR.js documentation`_ for more details if you want to run the web client from source.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` around lines 159 - 160, Remove
the duplicated sentence "for more details if you want to run the web client from
source" so it appears only once (keep the instance that follows the CloudXR.js
documentation reference), ensuring surrounding punctuation/spacing remains
correct; search for the exact phrase to locate and delete the redundant line in
the quick_start content.

246-246: ⚠️ Potential issue | 🟡 Minor

Add missing newline at end of file.

The file must end with a newline character to satisfy the end-of-file-fixer pre-commit hook.

📝 Proposed fix
 .. _`CloudXR teleoperation in Isaac Lab`: https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html
+
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 246, Add a missing
newline at end of file: ensure the last line containing ".. _`CloudXR network
setup`:
https://docs.nvidia.com/cloudxr-sdk/latest/requirement/network_setup.html#ports-and-firewalls"
is terminated with a single newline character so the file ends with a newline to
satisfy the end-of-file-fixer pre-commit hook.
README.md (1)

93-95: ⚠️ Potential issue | 🟡 Minor

Fix typos and complete the incomplete sentence.

Line 93 contains "Isaac Tepeop Core is design" (should be "designed"), and line 95 ends with the incomplete fragment "Teleoperation in ."

📝 Proposed fix
-Isaac Tepeop Core is design to work side by side with [NVIDIA Isaac Lab](https://github.com/isaac-sim/IsaacLab) starting with Isaac Lab 3.0 EA release.
+Isaac Teleop Core is designed to work side by side with [NVIDIA Isaac Lab](https://github.com/isaac-sim/IsaacLab) starting with the Isaac Lab 3.0 EA release.
 
-To get started, please refer to Isaac Lab's [Installation](https://isaac-sim.github.io/IsaacLab/main/source/setup/installation/index.html) guide for more details. Then follow the [CloudXR teleoperation in Isaac Lab](https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html) to get started with Teleoperation in .
+To get started, please refer to Isaac Lab's [Installation](https://isaac-sim.github.io/IsaacLab/main/source/setup/installation/index.html) guide for more details. Then follow the [CloudXR teleoperation in Isaac Lab](https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html) guide to get started with teleoperation in Isaac Lab.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 93 - 95, Fix the typos and complete the unfinished
sentence in the README: change "Isaac Tepeop Core is design" to "Isaac Teleop
Core is designed" (correct project name to "Isaac Teleop Core" and verb to
"designed") and finish the final sentence so the link reads "...to get started
with Teleoperation in Isaac Teleop Core." Update the two occurrences in the
README.md block around the Isaac Lab links (the sentence that introduces the
project and the final sentence that ends with "Teleoperation in .") so both
spelling and the incomplete fragment are corrected.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Line 45: Update the sentence "Teleoperate using only non-XR devices (e.g.
gamepad, Gello, haply, etc)" by adding a period after "etc" so it reads
"Teleoperate using only non-XR devices (e.g. gamepad, Gello, haply, etc.)."
Locate the exact string in README.md and replace the old punctuation
accordingly.

---

Duplicate comments:
In `@docs/source/getting_started/quick_start.rst`:
- Around line 133-134: Update the sentence containing "open this URL in your
headset's browser to connect to your headset" to clarify that the headset
connects to the workstation (e.g., replace "to your headset" with "to the
workstation"), and correct the typo "insetall" to "install" in the same
paragraph (search for the fragment "open this URL in your headset's browser" to
locate the text).
- Line 121: Fix the typo "Vision Pro cilent" by replacing "cilent" with "client"
wherever it appears (specifically update the sentence containing "Vision Pro
cilent" in the quick start text), e.g., change "Vision Pro cilent" to "Vision
Pro client" to correct the spelling in the documentation string.
- Around line 159-160: Remove the duplicated sentence "for more details if you
want to run the web client from source" so it appears only once (keep the
instance that follows the CloudXR.js documentation reference), ensuring
surrounding punctuation/spacing remains correct; search for the exact phrase to
locate and delete the redundant line in the quick_start content.
- Line 246: Add a missing newline at end of file: ensure the last line
containing ".. _`CloudXR network setup`:
https://docs.nvidia.com/cloudxr-sdk/latest/requirement/network_setup.html#ports-and-firewalls"
is terminated with a single newline character so the file ends with a newline to
satisfy the end-of-file-fixer pre-commit hook.

In `@README.md`:
- Around line 93-95: Fix the typos and complete the unfinished sentence in the
README: change "Isaac Tepeop Core is design" to "Isaac Teleop Core is designed"
(correct project name to "Isaac Teleop Core" and verb to "designed") and finish
the final sentence so the link reads "...to get started with Teleoperation in
Isaac Teleop Core." Update the two occurrences in the README.md block around the
Isaac Lab links (the sentence that introduces the project and the final sentence
that ends with "Teleoperation in .") so both spelling and the incomplete
fragment are corrected.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c5bb840f-e18c-4d20-8bb9-0c2017d98363

📥 Commits

Reviewing files that changed from the base of the PR and between 7b0fa9c and c79e4d3.

📒 Files selected for processing (2)
  • README.md
  • docs/source/getting_started/quick_start.rst

@jiwenc-nv jiwenc-nv force-pushed the jiwenc/docs-quickstart branch 2 times, most recently from dbabee3 to 9fbb75b Compare March 9, 2026 06:56
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (9)
README.md (2)

45-45: ⚠️ Potential issue | 🟡 Minor

Add period after "etc" for American English style.

In American English, the abbreviation "etc" requires a period.

📝 Proposed fix
-  - Teleoperate using only non-XR devices (e.g. gamepad, Gello, haply, etc)
+  - Teleoperate using only non-XR devices (e.g. gamepad, Gello, haply, etc.)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 45, Edit the README sentence "Teleoperate using only
non-XR devices (e.g. gamepad, Gello, haply, etc)" to follow American English
style by adding a period after "etc" so it reads "... etc."—locate and update
that exact string in the README to include the trailing period.

74-76: ⚠️ Potential issue | 🟡 Minor

Fix typos and complete the Isaac Lab handoff paragraph.

Multiple issues in the Isaac Lab integration paragraph:

  • Line 74: "Tepeop" should be "Teleop"
  • Line 74: "design" should be "designed"
  • Line 76: Incomplete sentence ends with "Teleoperation in ."
📝 Proposed fix
-Isaac Tepeop Core is design to work side by side with [NVIDIA Isaac Lab](https://github.com/isaac-sim/IsaacLab) starting with Isaac Lab 3.0 EA release.
+Isaac Teleop Core is designed to work side by side with [NVIDIA Isaac Lab](https://github.com/isaac-sim/IsaacLab) starting with the Isaac Lab 3.0 EA release.
 
-To get started, please refer to Isaac Lab's [Installation](https://isaac-sim.github.io/IsaacLab/main/source/setup/installation/index.html) guide for more details. Then follow the [CloudXR teleoperation in Isaac Lab](https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html) to get started with Teleoperation in .
+To get started, please refer to Isaac Lab's [Installation](https://isaac-sim.github.io/IsaacLab/main/source/setup/installation/index.html) guide for more details. Then follow the [CloudXR teleoperation in Isaac Lab](https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html) guide to get started with teleoperation in Isaac Lab.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 74 - 76, Fix the typos in the Isaac Lab integration
paragraph: change "Isaac Tepeop Core" to "Isaac Teleop Core" and "design" to
"designed", and complete the trailing sentence that reads "to get started with
Teleoperation in ." by referencing Isaac Lab explicitly (e.g., "then follow the
CloudXR teleoperation in Isaac Lab guide to get started with Teleoperation in
Isaac Lab"). Use the existing phrases "Isaac Teleop Core" and "CloudXR
teleoperation in Isaac Lab" to locate and update the paragraph.
docs/source/getting_started/quick_start.rst (5)

134-134: ⚠️ Potential issue | 🟡 Minor

Fix typo: "insetall" → "install".

Line 134 contains a typo in "or insetall a separate client."

📝 Proposed fix
-or insetall a separate client.
+or install a separate client.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 134, Replace the typo
"insetall" with "install" in the sentence containing "or insetall a separate
client." so the text reads "or install a separate client."; update that exact
token in the sentence to correct spelling (search for the string "or insetall a
separate client." to locate the occurrence).

159-160: ⚠️ Potential issue | 🟡 Minor

Remove duplicate sentence.

Lines 159-160 contain duplicate text: "for more details if you want to run the web client from source" appears twice.

📝 Proposed fix
 The source code for the web client is in the :code-dir:`deps/cloudxr/webxr_client/` directory. Follow
-the instructions in the official `CloudXR.js documentation`_ for more details if you want to run the web client from source.
-for more details if you want to run the web client from source.
+the instructions in the official `CloudXR.js documentation`_ for more details if you want to run the web client from source.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` around lines 159 - 160, Remove
the duplicated sentence "for more details if you want to run the web client from
source" in the docs content: locate the repeated phrase in the quick_start.rst
around the CloudXR.js documentation sentence and delete the redundant duplicate
so the paragraph reads only once and punctuation/spacing remains correct.

246-246: ⚠️ Potential issue | 🟡 Minor

Add missing newline at end of file.

The file should end with a newline character, as required by the end-of-file-fixer pre-commit hook.

📝 Proposed fix
 .. _`CloudXR teleoperation in Isaac Lab`: https://isaac-sim.github.io/IsaacLab/main/source/how-to/cloudxr_teleoperation.html
+
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 246, Add a trailing
newline character at the end of the file containing the line beginning with "..
_`CloudXR network setup`:
https://docs.nvidia.com/cloudxr-sdk/latest/requirement/network_setup.html#ports-and-firewalls"
so the file ends with a single newline (satisfying the end-of-file-fixer
pre-commit hook).

121-121: ⚠️ Potential issue | 🟡 Minor

Fix typo: "cilent" → "client".

Line 121 contains a typo in "Vision Pro cilent".

📝 Proposed fix
-running the CloudXR runtime and wss proxy in containerized environment; or using Vision Pro cilent).
+running the CloudXR runtime and wss proxy in containerized environment; or using Vision Pro client).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` at line 121, Replace the
misspelled word "cilent" with "client" in the Quick Start text where the phrase
"Vision Pro cilent" appears (in docs/source/getting_started/quick_start.rst);
update the sentence to read "Vision Pro client" so the documentation no longer
contains the typo.

133-134: ⚠️ Potential issue | 🟡 Minor

Fix the connection target wording.

Line 133 says "to connect to your headset," but this step actually connects the headset browser to the workstation running CloudXR. The current wording is confusing for first-time setup.

📝 Proposed fix
-You can just open this URL in your headset's browser to connect to your headset. No need to build
-or insetall a separate client.
+Open this URL in your headset's browser to connect to the workstation running CloudXR. No need to
+build or install a separate client.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/getting_started/quick_start.rst` around lines 133 - 134, The
sentence fragment "to connect to your headset" is misleading—update the wording
so it clearly states that the headset's browser is connecting to the workstation
running CloudXR; replace the line containing "to connect to your headset" with
something like "to open in your headset's browser and connect the headset's
browser to the workstation running CloudXR" (or similar) so first-time users
understand the direction of the connection.
docs/source/overview/ecosystem.rst (2)

131-133: ⚠️ Potential issue | 🟡 Minor

Use version-stable docs links instead of tree/main.

These plugin links (Manus Gloves, Generic 3-axis Pedal, OAK-D Camera) always resolve to the repository's main branch, so older published docs can send readers to plugin paths that no longer match the version they're reading. Prefer internal Sphinx refs or version-aware source links (pointing to a release/tag).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/overview/ecosystem.rst` around lines 131 - 133, Update the three
hardcoded "tree/main" links for the Manus Gloves Plugin, Generic 3-axis Pedal
Plugin, and OAK-D Camera Plugin so they are version-stable: replace the raw
GitHub "tree/main" URLs with either internal Sphinx cross-reference targets
(e.g., :ref: or reference roles pointing to local doc pages for these plugins)
or construct GitHub URLs that point to the current release tag (not "main")
using the project's version variable, ensuring the links resolve to the same
tag/version as the docs being built.

31-31: ⚠️ Potential issue | 🟡 Minor

Avoid publishing hardcoded support ETAs.

The hardcoded "Q2 2026" entries at lines 31, 34, 107, and 111 will become stale quickly and can mislead users if schedules change. For GA docs, prefer "TBD", "Planned", or link to a roadmap page that can be updated independently.

Also applies to: 34-34, 107-107, 111-111

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/source/overview/ecosystem.rst` at line 31, Replace the hardcoded "Q2
2026" occurrences in the document (the literal string "Q2 2026") with a
non-timebound placeholder such as "TBD" or "Planned", or replace them with a
link to a maintained roadmap page; update each occurrence (including the
duplicates) so the docs don't contain stale fixed ETAs and ensure the
placeholder or link includes brief context about where users can find the
authoritative schedule.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/source/references/requirements.rst`:
- Line 19: Update the CPU model string to use AMD's official capitalization:
replace the literal "**CPU**: AMD Ryzen Threadripper 7960x (Recommended)" with
"**CPU**: AMD Ryzen Threadripper 7960X (Recommended)" so the trailing model
character is an uppercase "X" (change the "7960x" token to "7960X").
- Line 12: Update the CPU architecture capitalization in the documented
requirement string "**CPU**: X86 or ARM (Jetson Thor)" by replacing "X86" with
the correct technical notation (e.g., "x86" or "x86_64" for 64-bit), so the line
reads something like "**CPU**: x86 or ARM (Jetson Thor)" or "**CPU**: x86_64 or
ARM (Jetson Thor)" depending on the intended precision.

---

Duplicate comments:
In `@docs/source/getting_started/quick_start.rst`:
- Line 134: Replace the typo "insetall" with "install" in the sentence
containing "or insetall a separate client." so the text reads "or install a
separate client."; update that exact token in the sentence to correct spelling
(search for the string "or insetall a separate client." to locate the
occurrence).
- Around line 159-160: Remove the duplicated sentence "for more details if you
want to run the web client from source" in the docs content: locate the repeated
phrase in the quick_start.rst around the CloudXR.js documentation sentence and
delete the redundant duplicate so the paragraph reads only once and
punctuation/spacing remains correct.
- Line 246: Add a trailing newline character at the end of the file containing
the line beginning with ".. _`CloudXR network setup`:
https://docs.nvidia.com/cloudxr-sdk/latest/requirement/network_setup.html#ports-and-firewalls"
so the file ends with a single newline (satisfying the end-of-file-fixer
pre-commit hook).
- Line 121: Replace the misspelled word "cilent" with "client" in the Quick
Start text where the phrase "Vision Pro cilent" appears (in
docs/source/getting_started/quick_start.rst); update the sentence to read
"Vision Pro client" so the documentation no longer contains the typo.
- Around line 133-134: The sentence fragment "to connect to your headset" is
misleading—update the wording so it clearly states that the headset's browser is
connecting to the workstation running CloudXR; replace the line containing "to
connect to your headset" with something like "to open in your headset's browser
and connect the headset's browser to the workstation running CloudXR" (or
similar) so first-time users understand the direction of the connection.

In `@docs/source/overview/ecosystem.rst`:
- Around line 131-133: Update the three hardcoded "tree/main" links for the
Manus Gloves Plugin, Generic 3-axis Pedal Plugin, and OAK-D Camera Plugin so
they are version-stable: replace the raw GitHub "tree/main" URLs with either
internal Sphinx cross-reference targets (e.g., :ref: or reference roles pointing
to local doc pages for these plugins) or construct GitHub URLs that point to the
current release tag (not "main") using the project's version variable, ensuring
the links resolve to the same tag/version as the docs being built.
- Line 31: Replace the hardcoded "Q2 2026" occurrences in the document (the
literal string "Q2 2026") with a non-timebound placeholder such as "TBD" or
"Planned", or replace them with a link to a maintained roadmap page; update each
occurrence (including the duplicates) so the docs don't contain stale fixed ETAs
and ensure the placeholder or link includes brief context about where users can
find the authoritative schedule.

In `@README.md`:
- Line 45: Edit the README sentence "Teleoperate using only non-XR devices (e.g.
gamepad, Gello, haply, etc)" to follow American English style by adding a period
after "etc" so it reads "... etc."—locate and update that exact string in the
README to include the trailing period.
- Around line 74-76: Fix the typos in the Isaac Lab integration paragraph:
change "Isaac Tepeop Core" to "Isaac Teleop Core" and "design" to "designed",
and complete the trailing sentence that reads "to get started with Teleoperation
in ." by referencing Isaac Lab explicitly (e.g., "then follow the CloudXR
teleoperation in Isaac Lab guide to get started with Teleoperation in Isaac
Lab"). Use the existing phrases "Isaac Teleop Core" and "CloudXR teleoperation
in Isaac Lab" to locate and update the paragraph.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 99ca602c-0841-4e01-8ad2-44fc2d19fd09

📥 Commits

Reviewing files that changed from the base of the PR and between c79e4d3 and dbabee3.

⛔ Files ignored due to path filters (1)
  • docs/source/_static/cloudxr-web-client-howto.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • README.md
  • docs/source/getting_started/build_from_source.rst
  • docs/source/getting_started/quick_start.rst
  • docs/source/index.rst
  • docs/source/overview/ecosystem.rst
  • docs/source/references/requirements.rst
  • scripts/run_isaac_lab.sh
💤 Files with no reviewable changes (1)
  • scripts/run_isaac_lab.sh

@jiwenc-nv jiwenc-nv enabled auto-merge (rebase) March 10, 2026 02:04
@jiwenc-nv jiwenc-nv merged commit 0e60322 into main Mar 10, 2026
37 checks passed
@jiwenc-nv jiwenc-nv deleted the jiwenc/docs-quickstart branch March 10, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants