Skip to content

Fix package version#236

Merged
aristarkhovNV merged 1 commit intomainfrom
aaristarkhov/fix-version
Mar 11, 2026
Merged

Fix package version#236
aristarkhovNV merged 1 commit intomainfrom
aaristarkhov/fix-version

Conversation

@aristarkhovNV
Copy link
Collaborator

@aristarkhovNV aristarkhovNV commented Mar 10, 2026

Fixes #234 -- isaacteleop.__version__ always report '1.0.0'

Summary by CodeRabbit

  • Tests

    • Added package version validation test to ensure correct Isaac Teleop version is deployed.
  • Chores

    • Updated test infrastructure to extract and verify package version from built wheels.
    • Modified package initialization to dynamically resolve version from distribution metadata with fallback for local development.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0716efc0-ce1c-44b4-863e-e633e07c6855

📥 Commits

Reviewing files that changed from the base of the PR and between e8b682c and 95dc069.

📒 Files selected for processing (4)
  • deps/cloudxr/docker-compose.test.yaml
  • examples/oxr/python/test_package_version.py
  • scripts/run_tests_with_cloudxr.sh
  • src/core/python/isaacteleop_init.py

📝 Walkthrough

Walkthrough

The changes fix the hardcoded __version__ issue by implementing dynamic version resolution using importlib.metadata, adding a test to validate package versions match wheel artifacts, and extracting version metadata from built wheels for test infrastructure.

Changes

Cohort / File(s) Summary
Version Resolution
src/core/python/isaacteleop_init.py
Replaced hardcoded __version__ = "1.0.0" with dynamic resolution via importlib.metadata.version("isaacteleop"), falling back to "0+unknown" if package metadata unavailable.
Test Implementation
examples/oxr/python/test_package_version.py
New test script that verifies isaacteleop.__version__ matches the expected version from the EXPECTED_ISAACTELEOP_VERSION environment variable.
Test Infrastructure
scripts/run_tests_with_cloudxr.sh, deps/cloudxr/docker-compose.test.yaml
Added wheel filename parsing to extract version into EXPECTED_ISAACTELEOP_VERSION variable; integrated test_package_version.py into GPU test suite and passed version through docker-compose configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A version was stuck in the past so long,
Now dynamic it flows where it belongs!
From wheel to the test, the truth rings clear,
No more frozen numbers, just truth sincere. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix package version' directly addresses the main objective of the PR, which is to fix isaacteleop.version reporting, making it concise and specific to the primary change.
Linked Issues check ✅ Passed The PR comprehensively addresses issue #234 by implementing dynamic version resolution from package metadata, ensuring version reflects the actual package version instead of hardcoded '1.0.0'.
Out of Scope Changes check ✅ Passed All changes are directly related to version handling: updating version resolution, adding test infrastructure for version validation, and extracting version from wheel files for testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aaristarkhov/fix-version

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes isaacteleop.__version__ to reflect the installed wheel/package metadata (instead of a hardcoded "1.0.0"), addressing issue #234 where detailed CI-generated versions (e.g., 1.0.125rc1) were not reported.

Changes:

  • Update isaacteleop.__version__ to use importlib.metadata.version("isaacteleop") with a local-source fallback.
  • Add a CI/container test that validates isaacteleop.__version__ against an expected version derived during the CloudXR test workflow.
  • Plumb the expected version into the CloudXR test environment via the runner script and docker-compose.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/core/python/isaacteleop_init.py Replace hardcoded version with package metadata version + fallback.
scripts/run_tests_with_cloudxr.sh Derive and export EXPECTED_ISAACTELEOP_VERSION for container tests.
examples/oxr/python/test_package_version.py New test asserting isaacteleop.__version__ matches CI-provided expected version.
deps/cloudxr/docker-compose.test.yaml Pass EXPECTED_ISAACTELEOP_VERSION into the test container environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aristarkhovNV aristarkhovNV merged commit ae87d32 into main Mar 11, 2026
37 checks passed
@aristarkhovNV aristarkhovNV deleted the aaristarkhov/fix-version branch March 11, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isaacteleop.__version__ always report '1.0.0'

3 participants