Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe changes fix the hardcoded Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
a803eb0 to
95dc069
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes isaacteleop.__version__ to reflect the installed wheel/package metadata (instead of a hardcoded "1.0.0"), addressing issue #234 where detailed CI-generated versions (e.g., 1.0.125rc1) were not reported.
Changes:
- Update
isaacteleop.__version__to useimportlib.metadata.version("isaacteleop")with a local-source fallback. - Add a CI/container test that validates
isaacteleop.__version__against an expected version derived during the CloudXR test workflow. - Plumb the expected version into the CloudXR test environment via the runner script and docker-compose.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/python/isaacteleop_init.py |
Replace hardcoded version with package metadata version + fallback. |
scripts/run_tests_with_cloudxr.sh |
Derive and export EXPECTED_ISAACTELEOP_VERSION for container tests. |
examples/oxr/python/test_package_version.py |
New test asserting isaacteleop.__version__ matches CI-provided expected version. |
deps/cloudxr/docker-compose.test.yaml |
Pass EXPECTED_ISAACTELEOP_VERSION into the test container environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #234 --
isaacteleop.__version__always report '1.0.0'Summary by CodeRabbit
Tests
Chores