Skip to content

Fix camera_streamer Docker build on ARM64#238

Merged
nv-mhaselton merged 1 commit intomainfrom
mhaselton/fix-camera-streamer-arm64
Mar 10, 2026
Merged

Fix camera_streamer Docker build on ARM64#238
nv-mhaselton merged 1 commit intomainfrom
mhaselton/fix-camera-streamer-arm64

Conversation

@nv-mhaselton
Copy link
Contributor

@nv-mhaselton nv-mhaselton commented Mar 10, 2026

ARM64 uses a newer base image.

Summary by CodeRabbit

  • Chores
    • Improved Docker installation compatibility for the camera streamer example.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

Adds the --break-system-packages flag to the uv pip install command in a Docker build configuration, allowing installation of packages in editable mode without system package conflicts.

Changes

Cohort / File(s) Summary
Docker Configuration
examples/camera_streamer/Dockerfile
Added --break-system-packages flag to pip install command to permit system package modifications during editable mode installation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A flag so small, yet oh so keen,
Makes Docker builds run smooth and clean,
System packages now align,
With editable installs, all is fine!
One tiny change, a hop and a bound,
Dependencies freed, without a sound! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding the --break-system-packages flag to fix Docker build issues on ARM64 architecture.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mhaselton/fix-camera-streamer-arm64

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@examples/camera_streamer/Dockerfile`:
- Line 117: The Dockerfile uses an unpinned Astral UV installer and then invokes
the uv CLI with the --break-system-packages flag (see the RUN line containing
"uv pip install --system --break-system-packages --no-cache-dir -e
/camera_streamer"); pin the installer URL used earlier to a specific uv release
(e.g., change the installer URL from https://astral.sh/uv/install.sh to a
versioned URL like https://astral.sh/uv/<VERSION>/install.sh) and rebuild so the
uv CLI behavior (and the --break-system-packages flag) is deterministic across
builds.
- Line 117: The Dockerfile currently runs the editable install (RUN uv pip
install --system --break-system-packages --no-cache-dir -e /camera_streamer)
while only pyproject.toml is present; change the build order so you first
install dependencies from pyproject.toml (using uv pip install without -e), then
COPY the full project sources into /camera_streamer, and only after that run the
editable install (uv pip install -e /camera_streamer) to avoid installing
against an incomplete source tree and to keep dependency cache layers stable.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 18af0735-e22f-4fd9-8387-73d765eb5f5a

📥 Commits

Reviewing files that changed from the base of the PR and between e8b682c and ccb88d7.

📒 Files selected for processing (1)
  • examples/camera_streamer/Dockerfile

@farbod-nv farbod-nv self-requested a review March 10, 2026 20:10
@nv-mhaselton nv-mhaselton enabled auto-merge (squash) March 10, 2026 20:11
@life1ess life1ess self-requested a review March 10, 2026 20:19
@nv-mhaselton nv-mhaselton merged commit dc41139 into main Mar 10, 2026
33 checks passed
@nv-mhaselton nv-mhaselton deleted the mhaselton/fix-camera-streamer-arm64 branch March 10, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants