Fix camera_streamer Docker build on ARM64#238
Conversation
📝 WalkthroughWalkthroughAdds the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/camera_streamer/Dockerfile`:
- Line 117: The Dockerfile uses an unpinned Astral UV installer and then invokes
the uv CLI with the --break-system-packages flag (see the RUN line containing
"uv pip install --system --break-system-packages --no-cache-dir -e
/camera_streamer"); pin the installer URL used earlier to a specific uv release
(e.g., change the installer URL from https://astral.sh/uv/install.sh to a
versioned URL like https://astral.sh/uv/<VERSION>/install.sh) and rebuild so the
uv CLI behavior (and the --break-system-packages flag) is deterministic across
builds.
- Line 117: The Dockerfile currently runs the editable install (RUN uv pip
install --system --break-system-packages --no-cache-dir -e /camera_streamer)
while only pyproject.toml is present; change the build order so you first
install dependencies from pyproject.toml (using uv pip install without -e), then
COPY the full project sources into /camera_streamer, and only after that run the
editable install (uv pip install -e /camera_streamer) to avoid installing
against an incomplete source tree and to keep dependency cache layers stable.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 18af0735-e22f-4fd9-8387-73d765eb5f5a
📒 Files selected for processing (1)
examples/camera_streamer/Dockerfile
ARM64 uses a newer base image.
Summary by CodeRabbit