Skip to content

Optionally disable SSL verification#1640

Draft
dagardner-nv wants to merge 5 commits intoNVIDIA:developfrom
dagardner-nv:david-ignore-ssl-verify
Draft

Optionally disable SSL verification#1640
dagardner-nv wants to merge 5 commits intoNVIDIA:developfrom
dagardner-nv:david-ignore-ssl-verify

Conversation

@dagardner-nv
Copy link
Contributor

Description

  • Disable SSL verification if the NAT_DISABLE_SSL_VERIFICATION environment variable is set to 1, true, or yes.
  • This is useful when using a self-hosted LLM using a self-signed SSL certificate.

TODO:

  • Tests
  • Documentation
  • Determine which LLM clients this does and doesn't cover

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

…-hosted LLM using a self-signed SSL certificate

Signed-off-by: David Gardner <dagardner@nvidia.com>
@dagardner-nv dagardner-nv self-assigned this Feb 24, 2026
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Feb 24, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 699362f7-2ffa-4904-ac3d-851ffab5d997

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@dagardner-nv
Copy link
Contributor Author

Prev attempt #1006

@dagardner-nv dagardner-nv added the skip-ci Optionally Skip CI for this PR label Mar 5, 2026
…avid-ignore-ssl-verify

Signed-off-by: David Gardner <dagardner@nvidia.com>
…avid-ignore-ssl-verify

Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Signed-off-by: David Gardner <dagardner@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality non-breaking Non-breaking change skip-ci Optionally Skip CI for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant