Add Redis Agent Memory Server as memory type#1702
Draft
justin-cechmanek wants to merge 9 commits intoNVIDIA:developfrom
Draft
Add Redis Agent Memory Server as memory type#1702justin-cechmanek wants to merge 9 commits intoNVIDIA:developfrom
justin-cechmanek wants to merge 9 commits intoNVIDIA:developfrom
Conversation
- Add package pyproject.toml, LICENSE, and LICENSE-3rd-party - Package will provide Redis Agent Memory Server as a NAT memory type Made-with: Cursor Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com> Made-with: Cursor
- Register packages/nvidia_nat_agent_memory_server in [tool.uv.workspace] members Made-with: Cursor Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com>
- Add nvidia-nat[agent-memory-server] extra and include in 'most' bundle Made-with: Cursor Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com>
- Add AgentMemoryServerEditor (add_items, search, remove_items) using agent-memory-client - Add AgentMemoryServerMemoryConfig with base_url and default_namespace - Register memory type via @register_memory and nat.components entry point - Add agent-memory-client dependency and setuptools/entry-point config in pyproject.toml Made-with: Cursor Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com>
- Add tests/test_agent_memory_editor.py following nvidia_nat_redis structure - Test add_items (success, empty list, conversation-derived text, skip no-text) - Test search (success, missing user_id, empty memories) - Test remove_items (by memory_id, by user_id, no-op when client lacks methods) - Fix editor to import ClientMemoryRecord/MemoryTypeEnum from agent_memory_client.models - Add nvidia-nat-agent-memory-server to tool.uv.sources (workspace = true) for resolution Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com> Made-with: Cursor
Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com>
ClientMemoryRecord has no metadata attribute; remove invalid assignment to fix type error and runtime. Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com> Made-with: Cursor
Signed-off-by: Justin Cechmanek <justin.cechmanek@redis.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
dnandakumar-nv
added
feature request
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new package
nvidia_nat_agent_memory_serverwhich enables using Redis Agent Memory Server as a memory type.Closes #1635
By Submitting this PR I confirm: