Add handling to pipeline environment substitution for empty strings#1458
Open
charlesbluca wants to merge 19 commits intoNVIDIA:mainfrom
Open
Add handling to pipeline environment substitution for empty strings#1458charlesbluca wants to merge 19 commits intoNVIDIA:mainfrom
charlesbluca wants to merge 19 commits intoNVIDIA:mainfrom
Conversation
main
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1457, modifying themainpull request workflow so that libmode tests are no longer getting skipped on all PRs againstmainIn doing the above, found that it's possible to error at the pipeline loading stage if relevant environment variables are set to an empty string (
""); an example of these failures in our libmode tests:https://github.com/NVIDIA/NeMo-Retriever/actions/runs/22584850034/job/65426873204
Repurposing this PR to add handling to our YAML pipeline substitution logic for this case
Checklist