Skip to content

Add handling to pipeline environment substitution for empty strings#1458

Open
charlesbluca wants to merge 19 commits intoNVIDIA:mainfrom
charlesbluca:start-running-main-libmode
Open

Add handling to pipeline environment substitution for empty strings#1458
charlesbluca wants to merge 19 commits intoNVIDIA:mainfrom
charlesbluca:start-running-main-libmode

Conversation

@charlesbluca
Copy link
Collaborator

@charlesbluca charlesbluca commented Mar 2, 2026

Description

Follow-up to #1457, modifying the main pull request workflow so that libmode tests are no longer getting skipped on all PRs against main

In doing the above, found that it's possible to error at the pipeline loading stage if relevant environment variables are set to an empty string (""); an example of these failures in our libmode tests:

https://github.com/NVIDIA/NeMo-Retriever/actions/runs/22584850034/job/65426873204

E           ValueError: Failed to parse YAML after environment variable substitution. Error: while parsing a flow node
E           expected the node content, but found ','
E             in "<unicode string>", line 55, column 11:
E                         ,
E                         ^
E           
E           --- Substituted Content ---
...
E                   yolox_endpoints: [
E                     "page-elements:8001",
E                     ,
E                   ]
...

Repurposing this PR to add handling to our YAML pipeline substitution logic for this case

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@charlesbluca charlesbluca requested a review from a team as a code owner March 2, 2026 15:47
@charlesbluca charlesbluca requested a review from edknv March 2, 2026 15:48
@charlesbluca charlesbluca changed the title Get libmode tests running on main Get libmode tests running on pull requests against main Mar 2, 2026
@charlesbluca charlesbluca changed the title Get libmode tests running on pull requests against main Add handling to pipeline environment substitution for empty strings Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant