Conversation
Signed-off-by: jwilber <jwilber@nvidia.com>
jwilber
requested review from
dorotat-nv,
jomitchellnv,
jstjohn,
pstjohn and
trvachov
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pstjohn
reviewed
Feb 5, 2026
| thd_enabled: true | ||
| use_sequence_packing: true | ||
| fp8_enabled: true | ||
| fp8_recipe: transformer_engine.common.recipe.DelayedScaling |
Collaborator
There was a problem hiding this comment.
let's use Float8BlockScaling
Comment on lines
119
to
141
| # Lingua 1B - FSDP2 with Context Parallelism | ||
| - config: L2_lingua_1b | ||
| task_cmd: train_fsdp2_cp | ||
| thd_enabled: false | ||
| use_sequence_packing: false | ||
| fp8_enabled: false | ||
| cp_enabled: true | ||
| cp_size: 2 | ||
| wandb_name: "llama3_lingua_1b__fsdp2__cp__${now:%Y%m%d-%H%M%S}__${gitsha:}" | ||
| job_name: "llama3-lingua-1b-fsdp2-cp" | ||
|
|
||
| # Lingua 1B - FSDP2 with Context Parallelism + FP8 | ||
| - config: L2_lingua_1b | ||
| task_cmd: train_fsdp2_cp | ||
| thd_enabled: false | ||
| use_sequence_packing: false | ||
| fp8_enabled: true | ||
| fp8_recipe: transformer_engine.common.recipe.DelayedScaling | ||
| fp8_format: HYBRID | ||
| cp_enabled: true | ||
| cp_size: 2 | ||
| wandb_name: "llama3_lingua_1b__fsdp2__cp__fp8__${now:%Y%m%d-%H%M%S}__${gitsha:}" | ||
| job_name: "llama3-lingua-1b-fsdp2-cp-fp8" |
Collaborator
There was a problem hiding this comment.
cp runs should probably use sequence packing, but we need to be careful to use cudnn>=9.18
Signed-off-by: jwilber <jwilber@nvidia.com>
Signed-off-by: jwilber <jwilber@nvidia.com>
Signed-off-by: jwilber <jwilber@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft llama3 configs.
(not yet tested).
Also updated schedule for runs (and added this info to README):
┌─────────────────────┬───────────────────────┐
│ Model │ Schedule │
├─────────────────────┼───────────────────────┤
│ esm2_native_te_650m │ Mon/Wed/Fri (1am PST) │
├─────────────────────┼───────────────────────┤
│ esm2_native_te_15b │ Mon/Wed/Fri (1am PST) │
├─────────────────────┼───────────────────────┤
│ llama3_native_te_1b │ Tue/Thu (1am PST) │
├─────────────────────┼───────────────────────┤
│ codonfm_ptl_te │ Tue/Thu (1am PST) │
└─────────────────────┴───────────────────────┘