Enable bugprone#9058
Draft
Jacobfaib wants to merge 25 commits into
Draft
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Jacobfaib
force-pushed
the
jacobf/2026-05-18/clang-tidy-bugprone-umbrella
branch
from
5d83c5e to
779d579
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
[skip-vdc][skip-docs][skip-tpt]
Jacobfaib
force-pushed
the
jacobf/2026-05-18/clang-tidy-bugprone-umbrella
branch
from
28555aa to
a98e77b
Compare
Contributor
Author
|
/ok to test |
miscco
requested changes
May 21, 2026
Comment on lines
+349
to
+353
| if constexpr (is_unsigned_v<_Lhs> && is_signed_v<_Rhs>) | ||
| { | ||
| _CCCL_ASSUME(__rhs < 0); | ||
| } | ||
| else if constexpr (is_unsigned_v<_Rhs> && is_signed_v<_Rhs>) | ||
| if constexpr (is_unsigned_v<_Rhs> && is_signed_v<_Lhs>) |
Contributor
There was a problem hiding this comment.
This looks like a bug fix, please pull out into separate PR @davebayer for viz
Contributor
Author
There was a problem hiding this comment.
@miscco This PR is not for review (at least not in its current state). It's the umbrella PR that collects all of the changes needed for the whole category. Once CI passes:
- I split each check into separate PRs.
- I revert all changes in this PR and enable the category in the root
.clang-tidy, while disabling all the checks that need fixes. - This PR (in reduced form) merges.
- Each separate fix PR then removes the disable and implements the fixes. These sub-PR's is where these kinds of comments should be posted, they'll just get lost here.
Contributor
Author
There was a problem hiding this comment.
This is what this PR will (eventually) look like #8438.
Contributor
|
Please also drop the sizeof check |
Contributor
😬 CI Workflow Results🟥 Finished in 1h 01m: Pass: 0%/1 | Total: 1h 01m | Max: 1h 01mSee results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes
Checklist