Update libcudacxx-style SKILL#9115
Conversation
📝 WalkthroughSummary by CodeRabbit
suggestion: Walkthrough This PR updates the libcudacxx coding-style documentation with rules for uniform constructor initialization and member naming, function declaration preferences and compile-time markers, forward-declaration/header guidance and type-qualifier text, and a ban on relying on deduction guides during initialization. Changes libcudacxx Coding-Style Guidelines Extensions
Suggested reviewers
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.agent/skills/libcudacxx-style/SKILL.md (1)
27-27: ⚡ Quick winsuggestion: These two rules are easy to read as conflicting: uniform initialization guidance can imply CTAD, while Line 102 forbids deduction-guide reliance. Add one clarifying sentence near Line 27 (or an example with explicit template args) to make the “no CTAD” constraint explicit in initialization examples.
Also applies to: 102-102
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9aa2cf52-cc49-493e-a96e-0c109b10d1e4
📒 Files selected for processing (1)
.agent/skills/libcudacxx-style/SKILL.md
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.agent/skills/libcudacxx-style/SKILL.md (1)
27-27: ⚡ Quick winsuggestion: Grammar correction: "not enforced to builtin types" should be "not enforced for builtin types".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8a581393-c3e0-4e50-bb91-56b30c8a62a5
📒 Files selected for processing (1)
.agent/skills/libcudacxx-style/SKILL.md
Description
Considering some CodeRabbit reviews and internal feedback, it makes sense to update
libcudacxx-styleSKILL to decrease the noise.The PR adds guidelines for uniform initialization, class/struct naming conventions, and type qualifiers. Include recommendations for function return types and header inclusion practices.