Fix CMake configure error on Windows in thrust benchmarks#9121
Open
miyanyan wants to merge 1 commit into
Open
Conversation
`thrust_wrap_bench_in_cpp` was constructing the `configure_file` output path
by appending the full absolute source path to `${CMAKE_CURRENT_BINARY_DIR}`.
On Windows this produced an invalid path containing two drive letters (e.g.
`build/.../D:/source/.../file.cu.cpp`), causing CMake to fail with "System
Error: Invalid argument".
Contributor
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughTwo independent configuration updates: Visual Studio artifacts excluded from version control, and benchmark wrapping CMake function refactored to use relative paths instead of absolute paths when naming generated wrapped ChangesBuild Configuration Updates
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I used vs2026 to configure cccl with
all-devpreset and found these errors:Non-CUDA benchmark targets wrap
.cufiles into generated.cppfiles. The wrapper output path was built from an absolute benchmark source path, which produces an invalid build-tree path on Windows because it embeds the drive prefix.Checklist