Various smaller fixes to fix compile issues with openmp, and a few missing vector math functions #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ingowald
commented
Jan 16, 2026
ingowald
commented
- added missing vec::operator+= and operator-=
- added missinv vec4::constructor from vec3+w (eg color +alpha)
- fixe dmissing hip_runtime include when run on hip
- a few __cubl_both fixes to work on both openmp and cuda
- fixed broken/missing include when used with hip compiler Signed-off-by: Ingo Wald <ingowald@gmail.com>
Signed-off-by: Ingo Wald <ingowald@gmail.com>
Signed-off-by: Ingo Wald <ingowald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.