-
Notifications
You must be signed in to change notification settings - Fork 131
Add support for FP32 and mixed precision in PDLP #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kh4ster
wants to merge
20
commits into
main
Choose a base branch
from
pdlp_fp32_and_mixed_precision_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6e309df
working fp32 support for PDLP no presolve no crossover
Kh4ster b9ac363
updade run_pdlp to allow for fp32
Kh4ster c7f6a24
Merge branch 'main' into pdlp_float32
Kh4ster 3d11bfd
Merge branch 'main' into pdlp_float32
Kh4ster c4e778e
support fp32 with presolve
Kh4ster 6a72668
implement and toggle mixed precision
Kh4ster c134104
Merge branch 'main' into mixed_precision_on
Kh4ster 76eef99
Merge branch 'main' into mixed_precision_on
Kh4ster ea37dd2
cleanup and doc
Kh4ster f8f673a
update doc
Kh4ster 64c5457
style cleanup
Kh4ster 342ba32
use || for all pdlp float instanciation
Kh4ster 366fd6a
address PR comments
Kh4ster abf13f3
add forgotten parameter
Kh4ster 2cb9ce5
Merge branch 'main' into pdlp_fp32_and_mixed_precision_support
Kh4ster db6b2a3
handle cuda version not supporting mixed precision
Kh4ster 410ec3c
Merge branch 'main' into pdlp_fp32_and_mixed_precision_support
Kh4ster a3dd383
fix compilation issue following the recent main merge
Kh4ster 14f9052
fix cuda version guard to check cusparse version dynamically
Kh4ster ab9e8eb
fix doc
Kh4ster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there another flag for fp32?
I think we should just have
--pdlp-precisionflag with options:default,single,double,mixedas options. This allows us the change the definition ofmixedin future.