Skip to content

fix: Hint at api.name config when 404 hits an API path segment mismatch#537

Open
kfelternv wants to merge 3 commits into
NVIDIA:mainfrom
kfelternv:nico-cli-api-name-404-hint
Open

fix: Hint at api.name config when 404 hits an API path segment mismatch#537
kfelternv wants to merge 3 commits into
NVIDIA:mainfrom
kfelternv:nico-cli-api-name-404-hint

Conversation

@kfelternv
Copy link
Copy Markdown
Contributor

@kfelternv kfelternv commented May 15, 2026

Based on a few bug reports, adding a small hint to direct users to the api.name configuration option would help debug 404s when using the cli with nico rest

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 15, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 66d69457-17a3-471e-bdde-4e33f8f63e18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@kfelternv kfelternv marked this pull request as ready for review May 15, 2026 19:10
@kfelternv kfelternv requested a review from a team as a code owner May 15, 2026 19:10
@github-actions
Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-05-15 19:12:19 UTC | Commit: 23cabcd

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
nico-flow 66 4 34 18 2 8
nico-nsm 82 2 28 43 9 0
nico-psm 67 4 35 18 2 8
nico-rest-api 100 6 53 30 3 8
nico-rest-cert-manager 65 4 34 18 1 8
nico-rest-db 66 4 34 18 2 8
nico-rest-site-agent 65 4 34 18 1 8
nico-rest-site-manager 65 4 34 18 1 8
nico-rest-workflow 67 4 35 18 2 8
TOTAL 643 36 321 199 23 64

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Copy link
Copy Markdown
Contributor

@thossain-nv thossain-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfelternv Could this confuse those who are using /forge?

Copy link
Copy Markdown
Contributor

@thossain-nv thossain-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the API will return a json structure for 404 responses where the source field is set to the API name, we could just hint that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants