Update nico_arch_diagram and change it to SVG format#1650
Open
Coco-Ben wants to merge 2 commits into
Open
Conversation
-e Signed-off-by: Peter Gambrill <pgambrill@nvidia.com>
Contributor
|
Review findings from the technical accuracy pass. I think this still needs changes before merge. Blocker:
Issue #1192 coverage:
I ran |
camify
approved these changes
May 19, 2026
- Also remove ecmascript from SVG code Signed-off-by: Peter Gambrill <pgambrill@nvidia.com>
732f67b to
38fc39f
Compare
|
🌿 Preview your docs: https://nvidia-preview-pull-request-1650.docs.buildwithfern.com/infra-controller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-e
Signed-off-by: Peter Gambrill pgambrill@nvidia.com
Description
Current version is out of date, and also doesn't scale well.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes