Skip to content

Use correct fields when parsing NMX-C response in nvlink-info command #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmcroberts97 merged 3 commits into from
May 21, 2026
Merged

Use correct fields when parsing NMX-C response in nvlink-info command #1842

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c9751c
fix: fields in nvlink-info command
tmcroberts97 May 20, 2026
981a0bb
Merge branch 'main' into fix/nvlink-info-admin-cli
rtamma-nv May 20, 2026
2ba8725
fix: formatting
tmcroberts97 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 38 additions & 23 deletions crates/admin-cli/src/machine/nvlink_info/cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,17 +146,20 @@ pub async fn handle_nvlink_info_populate(
})?;

let domain_uuid = list_json
.get("DomainUUID")
.get("server_header")
.and_then(|h| h.get("domain_uuid"))
.and_then(|v| v.as_str())
.filter(|s| !s.is_empty())
.ok_or_else(|| {
CarbideCliError::GenericError(
"No non-empty DomainUUID in NMX-C GPU list response".to_string(),
)
CarbideCliError::GenericError("No domain_uuid in NMX-C server_header".to_string())
})?
.parse::<uuid::Uuid>()
.map_err(|e| {
CarbideCliError::GenericError(format!("Failed to parse domain_uuid: {}", e))
})?;

let gpus_json = list_json
.get("Gpus")
.get("gpu_info_list")
.and_then(|v| v.as_array())
.ok_or_else(|| {
CarbideCliError::GenericError("No Gpus array in NMX-C GPU list response".to_string())
Expand All @@ -165,27 +168,46 @@ pub async fn handle_nvlink_info_populate(
let mut gpus: Vec<forgerpc::NvLinkGpu> = Vec::new();
for gpu_json in gpus_json {
let gpu_tray_index = gpu_json
.get("LocationInfo")
.and_then(|loc| loc.get("TrayIndex"))
.get("loc")
.and_then(|loc| loc.get("tray_index"))
.and_then(|v| v.as_i64())
.unwrap_or(0) as i32;
.map(|v| v as i32)
.ok_or_else(|| {
CarbideCliError::GenericError(
"GPU entry missing loc.tray_index in NMX-C GPU list response".to_string(),
)
})?;
if gpu_tray_index != tray_index {
continue;
}

let gpu_device_id = gpu_json
.get("DeviceID")
.get("gpu_id")
.and_then(|v| v.as_i64())
.unwrap_or(0) as i32;
.map(|v| v as i32)
.ok_or_else(|| {
CarbideCliError::GenericError(
"GPU entry missing gpu_id in NMX-C GPU list response".to_string(),
)
})?;
let gpu_device_uid = gpu_json
.get("DeviceUID")
.get("gpu_uid")
.and_then(|v| v.as_u64())
.unwrap_or(0);
.ok_or_else(|| {
CarbideCliError::GenericError(
"GPU entry missing gpu_uid in NMX-C GPU list response".to_string(),
)
})?;
let gpu_slot_id = gpu_json
.get("LocationInfo")
.and_then(|loc| loc.get("SlotID"))
.get("loc")
.and_then(|loc| loc.get("slot_id"))
.and_then(|v| v.as_i64())
.unwrap_or(0) as i32;
.map(|v| v as i32)
.ok_or_else(|| {
CarbideCliError::GenericError(
"GPU entry missing loc.slot_id in NMX-C GPU list response".to_string(),
)
})?;

gpus.push(forgerpc::NvLinkGpu {
device_id: gpu_device_id,
Expand All @@ -202,16 +224,9 @@ pub async fn handle_nvlink_info_populate(
)));
}

// Parse domain_uuid as UUID
let domain_uuid_parsed = uuid::Uuid::parse_str(domain_uuid).map_err(|e| {
CarbideCliError::GenericError(format!("Failed to parse domain_uuid: {}", e))
})?;

// Build the nvlink_info structure for RPC
let nvlink_info_rpc = forgerpc::MachineNvLinkInfo {
domain_uuid: Some(carbide_uuid::nvlink::NvLinkDomainId::from(
domain_uuid_parsed,
)),
domain_uuid: Some(carbide_uuid::nvlink::NvLinkDomainId::from(domain_uuid)),
gpus: gpus.clone(),
chassis_serial: serial_number.clone(),
};
Expand Down
Loading