fix(api,agent): Correct mapping of routing-profile to VPC on the DPU#1845
Merged
Conversation
bcavnvidia
force-pushed
the
routing-profile-per-vpc
branch
3 times, most recently
from
6ffd496 to
7364879
Compare
bcavnvidia
force-pushed
the
routing-profile-per-vpc
branch
from
7364879 to
88ca788
Compare
chet
approved these changes
May 21, 2026
bcavnvidia
commented
May 21, 2026
|
|
||
| // Route imports and tagging details for exports used by FNN configs. | ||
| // This is scoped to the VPC that owns this interface. | ||
| optional RoutingProfile routing_profile = 20; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Up to now, there was an assumption that all VPCs associated with an instance would use the same routing-profile, but that 1) wasn't explicitly enforce (only de facto), and 2) the assumption prevents things like having a single instance span two VPCs using profiles that differ only by their allowed anycast announcements.
This PR moves the FNN routing-profile handling from a single instance-level/VPC value to the actual per-VPC interface data sent to DPUs.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes