refactor(measured-boot): move grpc conversions into rpc crate#1853
Open
poroh wants to merge 1 commit into
Open
refactor(measured-boot): move grpc conversions into rpc crate#1853poroh wants to merge 1 commit into
poroh wants to merge 1 commit into
Conversation
Move measured-boot protobuf conversion traits and impls out of the measured-boot crate and into the rpc crate. This removes the transitional measured-boot -> rpc dependency and eliminates a transitive rpc dependency from downstream database/model crates. This is part of the broader effort to remove direct model -> rpc and db -> rpc dependencies by keeping grpc-specific conversion logic alongside the generated protobuf types. Also move measured-boot CLI table/summary helpers into the measured-boot crate so admin-cli output formatting no longer depends on rpc for those traits. Signed-off-by: Dmitry Porokh <dporokh@nvidia.com>
poroh
force-pushed
the
measured-boot-rpc-conv-to-rpc
branch
from
9d7549e to
27d3a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move measured-boot protobuf conversion traits and impls out of the measured-boot crate and into the rpc crate. This removes the transitional measured-boot -> rpc dependency and eliminates a transitive rpc dependency from downstream database/model crates.
This is part of the broader effort to remove direct model -> rpc and db -> rpc dependencies by keeping grpc-specific conversion logic alongside the generated protobuf types.
Also move measured-boot CLI table/summary helpers into the measured-boot crate so admin-cli output formatting no longer depends on rpc for those traits.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes