validate: gate PF section-header tint on actual conflict#68
Merged
Conversation
The Actual / Expected PF sub-tables in the Node groups section
previously got their red / orange header tint unconditionally. On
clusters where the discovered hardware matches the certified
topology cleanly, that surfaced a red "East-west PFs — Actual"
banner even though nothing was wrong — misleading at a glance.
This commit gates the header tint classes on whether any row in
that specific table is Mismatched (or, for the Actual east-west
header, whether the discovered PF count differs from the
certified topology's count). Groups whose Actual and Expected
line up render with a plain muted header now; only the tables
that actually drift get the red / orange band.
Added one tiny template helper, pfsHaveMismatch, that returns
true if any PFInfo in the list has Mismatched=true. The four
section headers compose it with the existing PFCountMismatch
check via {{or}}.
The golden file is unchanged because the existing fixture
already populates Mismatched rows in both tables — the tinted
path is what's exercised by the golden. The no-conflict branch
is exercised at runtime when validate runs against a cluster
that matches its preset cleanly.
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Actual / Expected PF sub-tables in the Node groups section previously got their red / orange header tint unconditionally. On clusters where the discovered hardware matches the certified topology cleanly, that surfaced a red "East-west PFs — Actual" banner even though nothing was wrong — misleading at a glance.
This commit gates the header tint classes on whether any row in that specific table is Mismatched (or, for the Actual east-west header, whether the discovered PF count differs from the certified topology's count). Groups whose Actual and Expected line up render with a plain muted header now; only the tables that actually drift get the red / orange band.
Added one tiny template helper, pfsHaveMismatch, that returns true if any PFInfo in the list has Mismatched=true. The four section headers compose it with the existing PFCountMismatch check via {{or}}.
The golden file is unchanged because the existing fixture already populates Mismatched rows in both tables — the tinted path is what's exercised by the golden. The no-conflict branch is exercised at runtime when validate runs against a cluster that matches its preset cleanly.