fix: Point cloud component meta data group#89
Merged
janickm merged 1 commit intoNVIDIA:mainfrom May 5, 2026
Merged
Conversation
janickm
force-pushed
the
dev/janickm/push-vwwrmvvvrqrk
branch
from
ee677bc to
7bd62ab
Compare
Serialization of point-clouds failed for itar stores that don't allowupdating existing group attributes - move to attributes of group levelinstead. This was a bug that prevented itar stores to be created, hence accept potentially invalid directory-based versions. Also extend unit tests to cover both store types + fix newly uncovered type issues due to the now type-checked functions.
janickm
force-pushed
the
dev/janickm/push-vwwrmvvvrqrk
branch
from
7bd62ab to
65dad42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialization of point-clouds failed for itar stores that don't allow
updating existing group attributes - move to attributes of group level
instead. This was a bug that prevented itar stores to be created, hence
accept potentially invalid directory-based versions.
Attribute schema storage and access improvements:
coordinate_unitare now written to and read from thepcsgroup attributes instead of the top-level group, ensuring support for itar files. (ncore/impl/data/v4/components.py) [1] [2] [3]Testing improvements:
ncore/impl/data/v4/components_test.pyare now parameterized to run for bothitaranddirectorystore types, improving coverage and reliability across backends. (ncore/impl/data/v4/components_test.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Test utility changes:
_make_writer_readerhelper now requires thestore_typeargument as a positional parameter, clarifying usage and preventing accidental omission. (ncore/impl/data/v4/components_test.py)