Fix incorrect PyBind11 headers target reference#365
Merged
ryanmrichard merged 2 commits intomasterfrom Jun 9, 2025
Merged
Conversation
Contributor
Author
|
ParallelZone uses nwx_add_pybind11_module() from the NWXCMake repository, while this repo does not. I would advise against merging this until:
|
ryanmrichard
previously approved these changes
Jun 9, 2025
Member
|
I'll probably forget about this PR while you work on the other issues. Please ping us again when this is r2g. |
jwaldrop107
previously approved these changes
Jun 9, 2025
Contributor
Author
|
@ryanmrichard @jwaldrop107 This should be r2g now. I made another commit updating a comment to make the tests rerun. |
jwaldrop107
approved these changes
Jun 9, 2025
ryanmrichard
approved these changes
Jun 9, 2025
Member
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
The current name used to reference the PyBind11 headers target (
pybind11_headers) only exists if PyBind11 is built with your project. If it is already installed, the exported target is insteadpybind11::headers. During the build,pybind11_headersis aliased topybind11::headers(here), so usingpybind11::headersexclusively should work in both scenarios.TODOs