Conversation
- NWX_MODULE_DIRECTORY is set correctly for all NWChemExBasePybindings-based packages - ParallelZone and PluginPlay bindings appear to be working - TensorWrapper and above are in-progress - The value of NWX_MODULE_DIRECTORY needs to be generalized to any Python version. It currently only works for Python 3.13.
|
@jwaldrop107 I think this is ready for another review. I need to check if I can build the whole thing, which will take time, but it all looks right from an surface-level check on my end. Questions/points of interest for this review:
|
jwaldrop107
left a comment
jwaldrop107
left a comment
There was a problem hiding this comment.
@zachcran In general, LGTM. The actions should be sufficient for the time being. I would say go ahead and remove the two _package.py files.
|
@jwaldrop107 Sorry, I forgot to click the "Ready for Review" button before. I hope that doesn't obstruct the review process much. The extra files have been removed. |
|
@jwaldrop107 I added some basic steps/tips to the README for development and testing of the packages. Let me know what you think and anything else that I may have missed or you think would be useful to add. Otherwise, I think this is good to go now. |
2 participants
Description
Python bindings are not currently working properly with Spack packaging. This PR works on solving that issue.
TODOs
+pythonflag correctly down the stack, sincenwchemex-tensorwrapper+pythonwas depending onnwchemex-parallelzone~pythonfor some reason.depends_on("nwchemex-parallelzone+python", when="+python").