Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions .github/workflows/browserstack.yml

This file was deleted.

130 changes: 0 additions & 130 deletions .github/workflows/cypress.yml

This file was deleted.

12 changes: 0 additions & 12 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
name: Playwright Tests for Web Reader
on:
schedule:
- cron: '00 14 * * 1-5' # every day at 9-10 AM ET (2 PM wherever the server is) excluding weekends
pull_request:
types: [opened, synchronize, reopened]
jobs:
Expand Down Expand Up @@ -58,13 +56,3 @@ jobs:
name: playwright-report
path: playwright-report/
retention-days: 30

- name: Slack Notification
if: ${{ always() }}
uses: rtCamp/action-slack-notify@v2
env:
SLACK_CHANNEL: test_reports
SLACK_MESSAGE: See "Test results" step in ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
SLACK_TITLE: Web Reader Playwright Test Results
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_USERNAME: nyplorgBot
4 changes: 0 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ coverage
# the parcel built example app
www

# cypress
cypress/screenshots
cypress/videos

# Playwright
/test-results/
/playwright-report/
Expand Down
22 changes: 1 addition & 21 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This project features an example application under `/example`, which is deployed
- [TypeScript](https://www.npmjs.com/package/typescript) - JavaScript with syntax for types
- [React](https://www.npmjs.com/package/react) - For creating user interface components
- [Jest](https://jestjs.io/) & [React Testing Library](https://testing-library.com/) - For writing unit tests
- The Example App is packaged with [Parcel](https://parceljs.org/) & deployed with [Vercel](https://vercel.com/). Integration tests are run with [Cypress](https://www.cypress.io/).
- The Example App is packaged with [Parcel](https://parceljs.org/) & deployed with [Vercel](https://vercel.com/).

## Features

Expand Down Expand Up @@ -230,7 +230,6 @@ C4 Models have been created to demonstrate how the WebReader and other web readi
This is the folder structure:

```txt
/cypress # cypress integration tests
/example # example app packaged by Parcel
index.html
index.tsx # entrypoint for the demo app
Expand Down Expand Up @@ -320,24 +319,6 @@ To run all the tests as they run in CI:
npm run test:ci
```

### Integration Tests with Cypress

The tests we have are located in the `cypress/integration` folder.

To properly run the tests, make sure the example app is running (Instruction above on how to set up the example page), cypress will test against that page by default. Or if the app is hosted elsewhere, update the `baseUrl` value in the `cypress.json` file to match your host URL.

To run and open an interactive testing envioment:

```bash
npm run cypress:open
```

To run tests on your terminal without a browser:

```bash
npm run cypress:cli
```

## Code Quality & Bundle Size Checks

- `npm run lint` to lint the code yourself. Code quality enforcement is set up in pre-commit hooks with `prettier`, `husky`, and `lint-staged`.
Expand All @@ -350,7 +331,6 @@ There are three Github Actions Workflows:

- `main` - installs deps w/ cache, lints, tests, and builds on all pushes against a Node and OS matrix
- `size` - comments cost comparison of your library on every pull request using [size-limit](https://github.com/ai/size-limit)
- `cypress` - runs the Cypress integration tests on Vercel deployments, which means it runs whenever a pull request is opened or updated

## Versioning

Expand Down
105 changes: 0 additions & 105 deletions browserstack.yml

This file was deleted.

5 changes: 0 additions & 5 deletions cypress/fixtures/example.json

This file was deleted.

Loading
Loading