Support navigation based on start URL parameter#204
Open
alea12 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jackiequach
approved these changes
May 15, 2026
Collaborator
jackiequach
left a comment
jackiequach
left a comment
There was a problem hiding this comment.
looks good, just a minor comment
| const { pageNumber: currentPage, resourceIndex } = state; | ||
|
|
||
| const currentHref = manifest.readingOrder[resourceIndex]?.href; | ||
| const startPage = getStartPageFromHref(currentHref) ?? 0; |
Collaborator
There was a problem hiding this comment.
startPage should default to 1 to be consistent with the rest of this reducer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the reducer to handle the
?startURL parameter on load. The logic was moved from a utility function edge case ingoToLocation()to thePDF_PARSEDaction for better consistency